Why does one star get pushed back when I enter a word into my square [closed] - c++

Question

Closed. This question needs debugging details. It is not currently accepting answers.
Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.
Closed yesterday.
Improve this question
The program below executes a drawing of a square with the words hello world written in it. The problem is that after the word the star(makes the square) is pushed forward beyond all other stars. How can I push that star back with the others?
#include <iostream>
void Square();
int main()
{
Square();
}
void Square()
{
for (int i = 0; i < 25; i++)
{
for (int k = 0; k < 25; k++)
{
if (i == 0 || k == 0 || i ==24 || k == 24)
{
std::cout << "*";
}
else
{
std::cout << " ";
}
if (i == 8 && k == 5)
{
std::cout << "Hello World";
}
}
std::cout << std::endl;
}
}

Answer 1

The problem is that the else statement of the first is statement
if (i == 0 || k == 0 || i ==24 || k == 24)
{
std::cout << "*";
}
else
{
std::cout << " ";
}
always gets the control when the condition of the if statement evaluates to false before and after the next if statement
if (i == 8 && k == 5)
{
std::cout << "Hello World";
}
in turn gets the control. And the length of the string "Hello World" is ignored.
Actually there is no need to use nested for loops. It is enough to use only one for loop and stream manipulators.
Here is a demonstration program.
#include <iostream>
#include <iomanip>
std::ostream & Square( std::ostream &os = std::cout )
{
const char s[] = "Hello World";
const size_t length = sizeof( s ) - 1;
const size_t N = 25;
const size_t left_indent = ( N - length ) / 2;
const size_t right_indent = N - length - left_indent;
for (size_t i = 0; i < N; i++)
{
if (i == 0 || i == N - 1)
{
os << std::setw( N ) << std::setfill( '*' ) << '*' << '\n';
}
else if (i == 8)
{
std::cout << '*' << std::setw( left_indent - 1 + length ) << s
<< std::setw( right_indent ) << '*' << '\n';;
}
else
{
os << '*' << std::setw( N - 1 ) << std::setfill( ' ' ) << '*' << '\n';
}
}
return os;
}
int main()
{
Square() << '\n';
}
The program output is
*************************
* *
* *
* *
* *
* *
* *
* *
* Hello World *
* *
* *
* *
* *
* *
* *
* *
* *
* *
* *
* *
* *
* *
* *
* *
*************************
Another approach is to use formatting features declared in the header <format> provided that your compiler supports C++ 20.