How can I get a cstring into a class? - c++

Question

I'm going to using cstring finish the program
now I required to get the name of PokemonWorld from user
and initialize it
But I can't get the cstring from main() into class PokemonWorld
I tried cin >> world.setName and cin >> name; world.setName(name)
both of which failed
class PokemonWorld {
private:
char name[10];
public:
void setName(char x[]) {
*name = x;
};
char* getName(){
return name;
};
};
void main() {
PokemonWorld world;
int number;
char name[10];
cout << "What is the World Name ?" ;
cin >> name;
world.setName(name);
Also I cannot using getName to return the name that assigned into PokemonWorld
Here is the error code:
Error C3867 'PokemonWorld::getName': non-standard syntax; use '&' to create a pointer to member
Should I create PokemonWorld as pointer?

Answer 1

With cstring, you have to use c string manipulator. You definitively can't assign an array to another one. For your issue, use strncpy_s:
void setName(char x[]) {
strncpy_s(name, 10, x, 10);
};
Also, to avoid issue, your getter should be:
const char * const getName() const {
return name;
};
Also, to compare, use strncmp, to concatenate use strncat, ...
Or, because you use c++, use std::string

Answer 2

You need to set the name first. In your main method,
PokemonWorld world;
int number;
char name[10];
cout << "What is the World Name ?" ;
cin >> name;
world.setName(name);
//Then get the name
world.getName(name);

Answer 3

You are not using a cstring (most people who hear "cstring" think of the CString class of the MFC library).
You are using a "C" string, or a raw char pointer. This is bad practice in general, as it involves performing memory management manually, and unless you solve the problems that come with using raw pointers, you will simply have those problems in your code.
setName should be:
void setName(char const * const x)
{
auto length = std::min(std::strlen(x), 9); // only copy up to 9 characters
std::copy_n(x, length, name);
name[length] = '\0';
}
... or (as already pointed out):
strncpy_s(name, 10, x, 10);
getName should be:
char const * const getName() const
{
return name;
}
This code is almost correct:
char name[10];
cout << "What is the World Name ?" ;
cin >> name;
world.setName(name);
... but you should initialize name where you declare it:
char name[10] = { 0 };
Also, what will you do if the user inputs more than 10 characters? In that case the stack of your program will become corrupted.
You could avoid the problem by using a std::string.