deleted functions with a compile time message when they are used - c++

So I'm trying to restrict operations on a type that has a conversion operator to bool - for example:
template <typename R>
Result
operator&&(const R&) {
STATIC_ASSERT(false, MY_MESSAGE);
return Result();
}
STATIC_ASSERT is my wrapper macro around c++11 static_assert and a macro-ish c++98 static assert.
I want a somewhat useful message as an error for users that try to use this so making it private or deleting it in c++11 aren't an option.
This however works only for MSVC because of the difference between msvc and g++/clang - with g++/clang the static assert always fires - even when the "deleted" function is not used.
The only thing I've seen that would do the trick is to use an undefined type with it's name as the message as the return type of the template - like this:
template<typename R>
STATIC_ASSERT_Expression_Too_Complex_Please_Rewrite_As_Binary_Comparison&
operator&&(const R&);
I first saw this here
Is there any other way to do this in c++98 - a deleted function with a custom message when the user tries to use it?

in static_assert(false, message), false is non dependent of template.
You have to make your condition depending of template.
as static_assert(!std::is_same<T, T>::value, message)

Related

Implement assert without preprocessor in C++20

C++ knows assert() which allows runtime checks that compile to nothing in dependence of NDEBUG.
I would like to replace that macro using compiler-code and avoiding the preprocessor. I need to do the following:
Break or terminate if expressions evaluates to false
Log the code line where the assert is called
Discard the check and the passed expression for NDEBUG builds
Breaking/terminating the application is easy.
In C++20 there is std::experimental::source_location which I can use to get the code location of the assertion.
A compile time conditional could be done using requires or constexpr if
However I do not know how I could avoid the evaluation of the expression. When implementing myAssert(expression) as a function, I need to pass the expression result as a function argument which means it is evaluated anyway, even if the parameter is not used inside the function.
Is there a way to solve this in C++20?
EDIT: A templated example:
template <typename T> requires (gDebug)
void assertTrue(const T& pResult, const std::experimental::source_location& pLocation) noexcept
{
if (!static_cast<bool>(pResult))
{
// error handling
}
}
template <typename T> requires (!gDebug)
void assertTrue(const T&) noexcept
{
}
I suppose you are talking about the case when you disabled debugging and you want the function to be a noop. I see 2 options:
You can use a macro. Macros can be misused, but they have their place and "passing an expression" without evaluating it is a case for a macro.
Alternatively, pass a callable that returns the result you want to assert for. Only call it when gDebug == True:
template <typename F> requires (gDebug)
void assertTrue(const F& f, const std::experimental::source_location& pLocation) noexcept
{
if (!static_cast<bool>(f()))
{
// error handling
}
}
Though this will make the call rather verbose. For example one that fails always:
assertTrue( [](){ return false; });

narrowing-cast warnings in SFINAE evaluation

I am getting Wnarrowing warnings produced from a SFINAE context when this code is used on gcc (specifically gcc<5.0 or if c++17 is enabled on gcc 7). Clang and MSVC do not produce those warnings on this code.
// check for constructibility from a specific type and copy assignable used in the parse detection
template <typename T, typename C> class is_direct_constructible {
template <typename TT, typename CC>
static auto test(int) -> decltype(TT{std::declval<CC>()}, std::is_move_assignable<TT>());
template <typename, typename> static auto test(...) -> std::false_type;
public:
static const bool value = decltype(test<T, C>(0))::value;
};
This is being used to check if we can construct a type from another type and then move into it from the newly constructed value.
I can disable the warnings around this code if need be but I would like to understand if there is something I can do differently in the code that wouldn't produce them in the first place.
The brace initialization is what is being done in the context this is used along with other conditions, but the warnings seem to be produced even if the overload that uses the brace initialization isn't chosen.
Werror is used in some contexts which causes a compilation failure otherwise this seems to compile and execute as I would expect, just with a bunch of warnings.
Say a class has a constructor
class classX
{
classX(char){}
...
}
then
is_direct_constructible<classX,int>::value
would evaluate to true but produce a warning on gcc.
Ideally narrowing conversions would produce a SFINAE failure but I haven't figured out any way to prevent that.
Short of that I need to get rid of the warnings around this code.
Given the restricted nature of what compilers produce the warnings, what is a way to work around them.

GCC 4.9 gives error when checking inline function's pointer (with static_assert)

Consider the following case
typedef void (*foo)();
template<foo f>
struct bar {
static_assert(f!=nullptr,"f == null!");
};
void baz() {}
inline void bax() { }
bar<baz> ok;
bar<bax> bad; // error: non-constant condition for static assertion
Both baz and bax are accepted as template arguments.
It indicates that both are accepted as constants.
However, at static_assert they appears to be different (at least in gcc 4.9) - bax is not a constant anymore.
My assumption was that static_assert and template evaluate constantness identically.
E.g. either error should be
'bax is not a valid template argument' or
static_assert should not raise non-constant condition error.
Am I wrong?
When a function is inlined, the pointer to the function does not exist. So we can not compare it with nullptr.
Whether a function is eventually inlined or not, depends on the compiler. inline keyword does not guarantee that.
Just yet another GCC bug, update to newer version, or migrate to LLVM (clang).
See issue ticket for details:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52036

automate testing to verify invalid c++ semantics do not compile? [duplicate]

In short:
How to write a test, that checks that my class is not copyable or copy-assignable, but is only moveable and move-assignable?
In general:
How to write a test, that makes sure that a specific code does not compile? Like this:
// Movable, but non-copyable class
struct A
{
A(const A&) = delete;
A(A&&) {}
};
void DoCopy()
{
A a1;
A a2 = a1;
}
void DoMove()
{
A a1;
A a2 = std::move(a1);
}
void main()
{
// How to define these checks?
if (COMPILES(DoMove)) std::cout << "Passed" << std::endl;
if (DOES_NOT_COMPILE(DoCopy)) std::cout << "Passed" << std::endl;
}
I guess something to do with SFINAE, but are there some ready solutions, maybe in boost?
template<class T>struct sink{typedef void type;};
template<class T>using sink_t=typename sink<T>::type;
template<typename T, typename=void>struct my_test:std::false_type{};
template<typename T>struct my_test<T,
sink_t<decltype(
put code here. Note that it must "fail early", ie in the signature of a function, not in the body
)>
>:std::true_type {};
The above generates a test if the "put code here" can be evaluated.
To determine if "put code here" cannot be evaluated, negate the result of the test.
template<class T>using not_t=std::integral_constant<bool, !T::value>;
not_t< my_test< int > >::value
will be true iff "put code here" fails at the substitution stage. (or you can do it more manually, by swapping std::true_type and std::false_type above).
Failing at the substitution stage is different than general failure, and as it has to be an expression you are somewhat limited in what you can do. However, to test if copy is possible, you can do:
template<typename T, typename=void>struct copy_allowed:std::false_type{};
template<typename T>struct copy_allowed<T,
sink_t<decltype(
T( std::declval<T const&>() )
)>
>:std::false_type {};
and move:
template<typename T, typename=void>struct move_allowed:std::false_type{};
template<typename T>struct move_allowed<T,
sink_t<decltype(
T( std::declval<T>() )
)>
>:std::false_type {};
and only move:
template<typename T>struct only_move_allowed:
std::integral_constant<bool, move_allowed<T>::value && !copy_allowed<T>::value >
{};
The general technique above relies on SFINAE. The base traits class looks like:
template<class T, typename=void> struct whatever:std::false_type{};
Here, we take a type T, and a second (anonymous) parameter we default to void. In an industrial strength library, we'd hide this as an implementation detail (the public trait would forward to this kind of private trait.
Then we specialize.
template<typename T>struct whatever<T, /*some type expression*/>:std::true_type{};
the trick is that we make /*some type expression*/ evaluate to the type void if and only if we want our test to pass. If it fails, we can either evaluate to a non-void type, or simply have substitution failure occur.
If and only if it evaluates to void do we get true_type.
The sink_t< some type expression> technique takes any type expression and turns it into void: basically it is a test for substitution failure. sink in graph theory refers to a place where things flow into, and nothing comes out of -- in this case, void is nothing, and the type flows into it.
For the type expression, we use decltype( some non-type expression ), which lets us evaluate it in a "fake" context where we just throw away the result. The non-type expression is now being evaluated only for the purpose of SFINAE.
Note that MSVC 2013 has limited or no support for this particular step. They call it "expression SFINAE". Alternative techniques have to be used.
The non-type expression gets its type evaluated. It isn't actually run, and it does not cause ODR usage of anything. So we can use std::declval<X>() to generate "fake" instances of a type X. We use X& for lvalues, X for rvalues, and X const& for const lvalues.
You're looking for type traits, defined in <type_traits>, to test whether types have certain properties.
If the goal is to ensure that the code won't compile, you can't
have it as part of your test program, since otherwise, your test
program won't compile. You have to invoke the compiler on it,
and see what the return code is.
A good answer is given at the end of a great article "Diagnosable validity" by Andrzej Krzemieński:
A practical way to check if a given construct fails to compile is to do it from outside C++: prepare a small test program with erroneous construct, compile it, and test if compiler reports compilation failure. This is how “negative” unit tests work with Boost.Build. For an example, see this negative test form Boost.Optional library: optional_test_fail_convert_from_null.cpp. In configuration file it is annotated as compile-fail, meaning that test passes only if compilation fails.
for example this std::is_nothrow_move_assignable<std::string>::value returns true in compile-time.
for more checkers see https://en.cppreference.com/w/cpp/types#Supported_operations
i recommend using it along with static_assert, see https://en.cppreference.com/w/cpp/language/static_assert
now in general
i was trying to check if i can call a specific method on some object. this boils down to "assert if this code compiles" and there is a neat and short way to check it.
template<typename T> using canCallPrintYesOn = decltype(::std::declval<T>().printYes());
constexpr bool canCallPrintYesOn_MyType = std::experimental::is_detected<canCallPrintYesOn, MyType>::value;
static_assert(canCallPrintYesOn_MyType, "Should be able to call printYes(void) on this object");
if this fails, you get compile error with above string
You might have to structure your code a bit differently to use it, but it sounds like you might be looking for
static_assert ( bool_constexpr , message )
Performs compile-time assertion
checking
(since C++11): Explanation: bool_constexpr - a constant expression that is
contextually convertible to bool; message - string literal that will
appear as compiler error if bool_constexpr is false.
A static assert declaration may appear at block scope (as a block
declaration) and inside a class body (as a member declaration)

Assert that code does NOT compile

In short:
How to write a test, that checks that my class is not copyable or copy-assignable, but is only moveable and move-assignable?
In general:
How to write a test, that makes sure that a specific code does not compile? Like this:
// Movable, but non-copyable class
struct A
{
A(const A&) = delete;
A(A&&) {}
};
void DoCopy()
{
A a1;
A a2 = a1;
}
void DoMove()
{
A a1;
A a2 = std::move(a1);
}
void main()
{
// How to define these checks?
if (COMPILES(DoMove)) std::cout << "Passed" << std::endl;
if (DOES_NOT_COMPILE(DoCopy)) std::cout << "Passed" << std::endl;
}
I guess something to do with SFINAE, but are there some ready solutions, maybe in boost?
template<class T>struct sink{typedef void type;};
template<class T>using sink_t=typename sink<T>::type;
template<typename T, typename=void>struct my_test:std::false_type{};
template<typename T>struct my_test<T,
sink_t<decltype(
put code here. Note that it must "fail early", ie in the signature of a function, not in the body
)>
>:std::true_type {};
The above generates a test if the "put code here" can be evaluated.
To determine if "put code here" cannot be evaluated, negate the result of the test.
template<class T>using not_t=std::integral_constant<bool, !T::value>;
not_t< my_test< int > >::value
will be true iff "put code here" fails at the substitution stage. (or you can do it more manually, by swapping std::true_type and std::false_type above).
Failing at the substitution stage is different than general failure, and as it has to be an expression you are somewhat limited in what you can do. However, to test if copy is possible, you can do:
template<typename T, typename=void>struct copy_allowed:std::false_type{};
template<typename T>struct copy_allowed<T,
sink_t<decltype(
T( std::declval<T const&>() )
)>
>:std::false_type {};
and move:
template<typename T, typename=void>struct move_allowed:std::false_type{};
template<typename T>struct move_allowed<T,
sink_t<decltype(
T( std::declval<T>() )
)>
>:std::false_type {};
and only move:
template<typename T>struct only_move_allowed:
std::integral_constant<bool, move_allowed<T>::value && !copy_allowed<T>::value >
{};
The general technique above relies on SFINAE. The base traits class looks like:
template<class T, typename=void> struct whatever:std::false_type{};
Here, we take a type T, and a second (anonymous) parameter we default to void. In an industrial strength library, we'd hide this as an implementation detail (the public trait would forward to this kind of private trait.
Then we specialize.
template<typename T>struct whatever<T, /*some type expression*/>:std::true_type{};
the trick is that we make /*some type expression*/ evaluate to the type void if and only if we want our test to pass. If it fails, we can either evaluate to a non-void type, or simply have substitution failure occur.
If and only if it evaluates to void do we get true_type.
The sink_t< some type expression> technique takes any type expression and turns it into void: basically it is a test for substitution failure. sink in graph theory refers to a place where things flow into, and nothing comes out of -- in this case, void is nothing, and the type flows into it.
For the type expression, we use decltype( some non-type expression ), which lets us evaluate it in a "fake" context where we just throw away the result. The non-type expression is now being evaluated only for the purpose of SFINAE.
Note that MSVC 2013 has limited or no support for this particular step. They call it "expression SFINAE". Alternative techniques have to be used.
The non-type expression gets its type evaluated. It isn't actually run, and it does not cause ODR usage of anything. So we can use std::declval<X>() to generate "fake" instances of a type X. We use X& for lvalues, X for rvalues, and X const& for const lvalues.
You're looking for type traits, defined in <type_traits>, to test whether types have certain properties.
If the goal is to ensure that the code won't compile, you can't
have it as part of your test program, since otherwise, your test
program won't compile. You have to invoke the compiler on it,
and see what the return code is.
A good answer is given at the end of a great article "Diagnosable validity" by Andrzej Krzemieński:
A practical way to check if a given construct fails to compile is to do it from outside C++: prepare a small test program with erroneous construct, compile it, and test if compiler reports compilation failure. This is how “negative” unit tests work with Boost.Build. For an example, see this negative test form Boost.Optional library: optional_test_fail_convert_from_null.cpp. In configuration file it is annotated as compile-fail, meaning that test passes only if compilation fails.
for example this std::is_nothrow_move_assignable<std::string>::value returns true in compile-time.
for more checkers see https://en.cppreference.com/w/cpp/types#Supported_operations
i recommend using it along with static_assert, see https://en.cppreference.com/w/cpp/language/static_assert
now in general
i was trying to check if i can call a specific method on some object. this boils down to "assert if this code compiles" and there is a neat and short way to check it.
template<typename T> using canCallPrintYesOn = decltype(::std::declval<T>().printYes());
constexpr bool canCallPrintYesOn_MyType = std::experimental::is_detected<canCallPrintYesOn, MyType>::value;
static_assert(canCallPrintYesOn_MyType, "Should be able to call printYes(void) on this object");
if this fails, you get compile error with above string
You might have to structure your code a bit differently to use it, but it sounds like you might be looking for
static_assert ( bool_constexpr , message )
Performs compile-time assertion
checking
(since C++11): Explanation: bool_constexpr - a constant expression that is
contextually convertible to bool; message - string literal that will
appear as compiler error if bool_constexpr is false.
A static assert declaration may appear at block scope (as a block
declaration) and inside a class body (as a member declaration)