Pugixml parse result object causes stack corruption - mfc

Question

MAJOR EDIT: I now have a much shorter error description!
I have an MFCx64 c++ program where InitInstace() is calling a ReadXML function that uses pugixml (latest version 1.13). Pugixml was compiled by including the pugixml.cpp file into the project. The creation of a pugi::xml_parse_result object is then causing a stack corruption when exiting the ReadXML function.
Minimum code causing the error:
int CMyApp::ReadXML_debug()
{
pugi::xml_parse_result result1;
return 0; //program will throw exception when leaving the function
}
BOOL CMyApp::InitInstance()
{
int test = ReadXML_debug();
//rest of InitInstance() here...
}
When the code leaves the ReadXML() function I get this exception: Run-Time Check Failure #2 - Stack around the variable 'result1' was corrupted. Stack corruption happens in both release and debug (but some more code lines might be needed to avoid the result1 object to be optimized away in release).
What in this very minimalistic code could be causing a stack corruption???
It should be noted that, of course, this was originally part of a much bigger code base. Initially the problematic code line was status = the_params->load_file(file).status; but that was much harder to debug. I have now found that it was the creation of the intermediate xml_parse_result object returned by load_file() that was causing the stack corruption.
More details about the compiler settings causing this error:
Studio: VS2019
Platform: x64
Build: Both Debug and Release
Toolset: Visual Studio 2019 (v142)
MFC in a static library
Runtime library: /MT or /MTd
Struct alignment: Default
------------------ END OF MAJOR EDIT, remaining part of original post below -------------
int config_params::load(const char* file)
{
int status = -1;
//Writing the code like this does not throw the stack corruption exception, but I get stack corruption (corrupted data) in the calling function.
//status = the_params->load_file(file).status;
// Rewrote code like this in order to find error
pugi::xml_parse_result result = the_params->load_file(file);
pugi::xml_parse_status statusTmp = result.status;
status = (int)statusTmp;
return status;
} //stack corruption exception triggered when leaving this function
When running in debug mode I get the exception Run-Time Check Failure #2 - Stack around the variable 'result' was corrupted. When running in release mode I get a similar exception: Stack cookie instrumentation code detected a stack-based buffer overrun.
Additional information: config_params is a singleton class that keeps the pugixml doc object.
// Singleton class for the xml parameters
class config_params : public params
{
public:
~config_params();
static config_params& get_instance()
{
static config_params instance; // Guaranteed to be destroyed.
// Instantiated on first use.
return instance;
}
virtual int init();
virtual int load(const char* xml_file);
private:
// Default constructor an xml abstraction layer for configuration parameter files
config_params();
static config_params* instance;
pugi::xml_document* the_params;
};
config_params::config_params()
{
the_params = new pugi::xml_document;
}
config_params::~config_params()
{
if (the_params)
{
delete (pugi::xml_document*)the_params;
}
}
int config_params::init()
{
int status = -1;
// This creates the file path (my code uses an actual xml file of course)
char filePath[500];
sprintf_s(filePath, "%s%s", "C:\\inserting_file_path", "\\here.xml");
//This gets the instance and loads the file
status = config_params::get_instance().load(filePath);
return status;
}
When my program starts, the InitInstance() function will call status = config_params::get_instance().init(); This call will first run the constructor, creating the new pugi::xml_document. Then init runs, calling load that reads the xml file. Finally, load function will exit and trigger the stack corruption exception. Alternatively, if the exception is not triggered, I will see stack corruption in InitInstance(), including a corrupted this pointer.
I have been debugging this a lot, changing around in the code. I have also tried to edit the load function, so that it does not read anything into the_params (the member pugi::xml_document). Instead the load function looked like this, still causing the stack corruption when leaving the function.
pugi::xml_document myDoc;
myDoc.load_file(file);
pugi::xml_parse_status statusTmp = result.status;
status = (int)statusTmp;
return status;
The xml documents are not especially big. They vary in content, but this would be a simple example:
<?xml version="1.0"?>
<PARAMETERS>
<Name>Register parameters</Name>
<VOLUME test="1" />
</PARAMETERS>
What could be triggering the stack corruption?
Final note: This is somewhat related to my previous question, in which pugixml was compiled as a very faulty dll file. Now I have thrown out that DLL and the problem is very different, so I am posting as a new question. (InitInstance(): pugixml corrupts my this pointer)