Restrict users to see detailview based on model field value in Django - django

Question

I am learning and have a change management project where my model contains field confidential which is by default False, however during instance creation so called initiator could tick it as True. This basically means that only users which are part of current record so called signees could open and see the instance. I am trying to apply get_queryset override on my DetailView:
# MOC DetailView
class MocDetailView(LoginRequiredMixin, DetailView):
model = Moc
template_name = 'moc/moc_detail.html'
def get_queryset(self, *args, **kwargs):
qs = super().get_queryset(*args, **kwargs)
for obj in qs:
print(obj)
confidential = obj.confidential
initiator = obj.initiator
coordinators = obj.coordinators.all()
reviewers = obj.reviewers.all()
approvers = obj.approvers.all()
preimplements = obj.preimplements.all()
authorizers = obj.authorizers.all()
postimplements = obj.postimplements.all()
closers = obj.closers.all()
if initiator and initiator == self.request.user and confidential == True:
qs = qs.filter(Q(confidential=True) & Q(initiator=self.request.user))
return qs
for signee in coordinators:
coordinator_name = signee.coordinator_name
if coordinator_name and coordinator_name == self.request.user and confidential == True:
qs = qs.filter(Q(confidential=True) & Q(coordinators__coordinator_name=self.request.user))
return qs
for signee in reviewers:
reviewer_name = signee.reviewer_name
if reviewer_name and reviewer_name == self.request.user and confidential == True:
qs = qs.filter(Q(confidential=True) & Q(reviewers__reviewer_name=self.request.user))
return qs
for signee in approvers:
approver_name = signee.approver_name
if approver_name and approver_name == self.request.user and confidential == True:
qs = qs.filter(Q(confidential=True) & Q(approvers__approver_name=self.request.user))
return qs
for signee in preimplements:
actionee_name = signee.actionee_name
if actionee_name and actionee_name == self.request.user and confidential == True:
qs = qs.filter(Q(confidential=True) & Q(preimplements__actionee_name=self.request.user))
return qs
for signee in authorizers:
authorizer_name = signee.authorizer_name
if authorizer_name and authorizer_name == self.request.user and confidential == True:
qs = qs.filter(Q(confidential=True) & Q(authorizers__authorizer_name=self.request.user))
return qs
for signee in postimplements:
actionee_name = signee.actionee_name
if actionee_name and actionee_name == self.request.user and confidential == True:
qs = qs.filter(Q(confidential=True) & Q(postimplements__actionee_name=self.request.user))
return qs
for signee in closers:
closer_name = signee.closer_name
if closer_name and closer_name == self.request.user and confidential == True:
qs = qs.filter(Q(confidential=True) & Q(closers__closer_name=self.request.user))
return qs
This allows to restrict Users only to those who are my signees, but in case my confidential field is False non of them are able to open those model instances.
Is there any where I introduce logic here to allow straight opening of non confidential model instance?
Appreciate your help...
Update
# MOC model
class Moc(models.Model):
moc_status = FSMField(choices=STATES, default='draft', protected=False)
initiator = models.ForeignKey(User, blank=True, null=True, on_delete=models.CASCADE)
area = models.ForeignKey(Area, related_name='area_moc', blank=True, null=True, on_delete=models.CASCADE)
category = models.ForeignKey(Category, related_name='category_moc', blank=True, null=True, on_delete=models.CASCADE)
confidential = models.BooleanField(default=False)
# Verifier model
class Verifier(models.Model):
moc = models.ForeignKey(Moc, related_name='verifiers', on_delete=models.CASCADE, default='1')
verifier_group = models.CharField(max_length=36, blank=True, null=True)
verifier_name = models.ForeignKey(User, blank=True, null=True, on_delete=models.CASCADE,)
verify_due = models.DateField(blank=True, null=True)
# Coordinator model
class Coordinator(models.Model):
moc = models.ForeignKey(Moc, related_name='coordinators', on_delete=models.CASCADE, default='1')
cooridnator_group = models.CharField(max_length=36, blank=True, null=True)
coordinator_name = models.ForeignKey(User, blank=True, null=True, on_delete=models.CASCADE,)
coordinator_due = models.DateField(blank=True, null=True)
..... so on so forth for all above listed signees.....

Answer 1

I have resolved it by the following code modification:
class MocDetailView(LoginRequiredMixin, DetailView):
model = Moc
template_name = 'moc/moc_detail.html'
context_object_name = 'moc'
def get_object(self, queryset=None):
obj = super(MocDetailView, self).get_object(queryset=queryset)
print(obj)
confidential = obj.confidential
initiator = obj.initiator
# verifiers = obj.verifiers.all()
verifier = obj.verifiers.filter(verifier_name=self.request.user)
print(verifier)
# coordinators = obj.coordinators.all()
coordinator = obj.coordinators.filter(coordinator_name=self.request.user)
print(coordinator)
# reviewers = obj.reviewers.all()
reviewer = obj.reviewers.filter(reviewer_name=self.request.user)
print(reviewer)
# approvers = obj.approvers.all()
approver = obj.approvers.filter(approver_name=self.request.user)
print(approver)
# preimplements = obj.preimplements.all()
preimplement = obj.preimplements.filter(actionee_name=self.request.user)
print(preimplement)
# authorizers = obj.authorizers.all()
authorizer = obj.authorizers.filter(authorizer_name=self.request.user)
print(authorizer)
# postimplements = obj.postimplements.all()
postimplement = obj.postimplements.filter(actionee_name=self.request.user)
print(postimplement)
# closers = obj.closers.all()
closer = obj.closers.filter(closer_name=self.request.user)
print(closer)
if self.request.user.is_superuser or initiator == self.request.user or verifier or coordinator or reviewer or approver or preimplement or authorizer or postimplement or closer and confidential == True:
return obj
elif not confidential:
return obj
else:
raise Http404()