Maximum sum subarray, C++, DSA [closed] - c++

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.
This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.
Closed 10 months ago.
Improve this question
I had tried to write a program to find the maximum sum subarray, I am able to take the output correctly in a certain scenario but if I want to change it the output is not as desired. So anyone can help me?
#include<iostream>
using namespace std;
int main(){
int minValue,n;
int a[n]={4,-2,-3,4,-1,-2,1,5,-3};
int max_so_far = minValue;
int max_ending_here=0;
int start=0, end=0, s=0;
for(int i=0; i<n;i++){
max_ending_here = max_ending_here+a[i];
if(max_so_far < max_ending_here){
max_so_far = max_ending_here;
start=s;
end = i;
}
if(max_ending_here<0){
max_ending_here=0;
s = i+1;
}
start=s;
}
cout<<"maximum sum subarray is: "<<max_so_far;
cout<<"\nstart "<<start;
//cout<<"\nend "<<end;
return 0;
}
The output of this code is:
maximum sum subarray is: 7
start 3
But if I try to print the value of end as well as shown in the following program:
#include<iostream>
using namespace std;
int main()
{
int minValue,n;
int a[n]={4,-2,-3,4,-1,-2,1,5,-3};
int max_so_far = minValue;
int max_ending_here=0;
int start=0, end=0, s=0;
for(int i=0; i<n;i++)
{
max_ending_here = max_ending_here+a[i];
if(max_so_far < max_ending_here){
max_so_far = max_ending_here;
start=s;
end = i;
}
if(max_ending_here<0){
max_ending_here=0;
s = i+1;
}
start=s;
}
cout<<"maximum sum subarray is: "<<max_so_far;
cout<<"\nstart "<<start;
cout<<"\nend "<<end;
return 0;
}
The output becomes as:
maximum sum subarray is: 32760
start 3
end 0
Can anybody point out the actual error for me?

Answer 1

Here I made 2 changes:
Used INT_MIN
Used vector instead of array definition.
#include<iostream>
using namespace std;
int main()
{
vector<int> a ={4,-2,-3,4,-1,-2,1,5,-3}; // <------------ here
int minValue=INT_MIN, n= a.size(); // <--------- here
int max_so_far = minValue;
int max_ending_here=0;
int start=0, end=0, s=0;
for(int i=0; i<n;i++)
{
max_ending_here = max_ending_here+a[i];
if(max_so_far < max_ending_here){
max_so_far = max_ending_here;
start=s;
end = i;
}
if(max_ending_here<0){
max_ending_here=0;
s = i+1;
}
start=s;
}
cout<<"maximum sum subarray is: "<<max_so_far;
cout<<"\nstart "<<start;
cout<<"\nend "<<end;
return 0;
}
OUTPUT:
maximum sum subarray is: 7
start 3
end 7