Reverse a string C++ [closed] - c++

Question

Closed. This question needs debugging details. It is not currently accepting answers.
Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.
Closed 2 years ago.
Improve this question
I'm new to programming. I've learned how to reverse a string today. I've tried to use string instead of char but terminal gives an error.
string name = { "george" };
int nChar = sizeof(name) - 1;
string *pName = &name;
string *pNameLast = &name + nChar - 1;
while(pName < pNameLast) {
string save = *pName;
*pName = *pNameLast;
*pNameLast = save;
pName++;
pNameLast--;
}
cout << name << endl;

Answer 1

Here is an example of using std::reverse_interator. This is better a better way of doing it. Rather than doing it yourself.
#include <iostream>
#include <string>
#include <iterator>
int main()
{
std::string s = "George";
std::reverse_iterator<std::string::iterator> r = s.rbegin();
std::string rev(r, s.rend());
std::cout << rev << endl;
}

Answer 2

Problem:
When you attempt to do operations like string *pName = &name and
string *pNameLast = &name + nChar - 1;, you're treating std::string's as char*'s. You cannot do that and expect the code to work.
Solution:
Treat std::string's as std::string's. Instead of doing string *pName = &name declare pName as an int and use the operator [] of std::string to access to the values. Similarly with pNameLast. You also have to declare string save as a char or, as I prefer, use the std::swap function.
Additional info:
As far as I can see you're probably using using namespace std; as you're declaring std::string as string. If that is the case consider that using namespace std; is considered a bad practice (More info here).
Full code:
#include <iostream>
int main() {
std::string name = "george";
int length = name.size();
int pNameFirst = 0;
int pNameLast = length - 1;
while(pNameFirst < pNameLast)
{
std::swap(name[pNameFirst],name[pNameLast]);
pNameFirst++;
pNameLast--;
}
std::cout << name << std::endl;
}

Answer 3

If you want to reverse a string object, just do the following (note this is the one of many handmade ways:
#include <iostream>
#include <string>
int main() {
std::string my_string{"hello"};
// Similar to your way:
int index{static_cast<int>(my_string.length() - 1)};
for (; index >= 0; --index) {
std::cout << my_string.at(index) << std::endl;
}
}