Don't know what generates this 'Segmentation Fault' error - c++
I'm currently making a simulation of an autonomous car for my AI class. The car's constructor receives the board as a parameter so it can set the position of the car and add the first node to the search tree, so it can search an optimum path from the Starting Position to the Finishing Position. The thing is, the board generates without any problem, but when I try to pass it to the car's constructor, it results in a Segmentation fault (core dumped) error.
I used a debugger (gdb), ran the code in it and made a back-trace; and the problem came from here:
void node_c::add_child(node_c* chld)
{ int i;
for (i = 0; i < MAX_CHILDREN; i++)
{ if (children_[i] == NULL) //This line's the problem
break;
}
if (children_[i] != NULL)
{ cout << endl << "You can't add any more children." << endl;
return;
}
else children_[i] = chld;
}
Note: 'children_' contains a maximum of 4 children of a search_tree's node, and is a custom vector_c class I had to make.
This is the operator that fails and the function it calls:
template <typename TDato>
TDato& vector_c<TDato>::operator [](int position) { return get_data(position); }
template <typename TDato>
TDato& vector_c<TDato>::get_data(int a) const { return data_[a]; }
I thought that it might be a type error in the comparison if (children_[i] == NULL) so I made a custom operator that returned an object (TDato), not a reference to an object (TDato&), but it didn't work.
I can't imagine what could be causing this and/or how to solve it.
Thanks in advance.
Edit 1: Here's a google drive link to the project as even a minimal reproducible example would be too large to be easy to read in a Stack Overflow question. It's not very big, I promise (less than 1 MB).
Edit 2: Here's the most I could do to make the reproducible example minimal, as the question got closed for not including it.
main.cpp
#include "../include/board_s.hpp"
#include "../include/car_c.hpp"
using namespace std;
int main(void)
{ board_s<int> board(20, 20);
board.file_depiction();
car_c car(board);
board.write(cout);
return 0;
}
Here, the problem comes when the constructor of car_c is called. It should create an car_c object.
board_c.hpp
#ifndef __BOARD_S__
#define __BOARD_S__
#include <cstdio>
#include <iostream>
#include <cstring>
#include <random>
#include <fstream>
#include <utility>
#include "matrix_c.hpp"
#include "tree_c.hpp"
using namespace std;
template <typename TDato = int>
class board_s: public matrix_c<TDato>
{ private:
pair<int, int> starting_pos;
pair<int, int> finishing_pos;
public:
board_s(int, int);
~board_s(void);
pair<int, int> get_start(void);
void file_depiction(void); //Generates obstacles and starting/finishing points as depicted in board_depiction.txt.
virtual ostream& write(ostream&);
int distance(pair<int, int>&) const; //Returns the distance from a given position to the finishing point
private:
bool object_setter(string, int&, int&);
int object_identifier(string&) const; //Given the name of the object ("NEW OBSTACLE" [1], "STARTING POSITION" [2] or "FINISHING POSITION" [3]) returns it's code
};
template class board_s<int>;
#endif
board_c.cpp
#include "../include/board_s.hpp"
#include "matrix_c.cpp"
using namespace std;
//The constructor fills the board with empty boxes.
template <typename TDato>
board_s<TDato>::board_s(int m, int n):
matrix_c<TDato>::matrix_c(m + 2, n + 2)
{ for(int i = 1; i < m; i++)
for(int j = 1; j < n; j++)
matrix_c<TDato>::at(i, j) = 0;
for(int i = 0; i < n + 2; i++)
{ matrix_c<TDato>::at(0, i) = 1;
matrix_c<TDato>::at(m + 1, i) = 1;
}
for(int i = 0; i < m + 2; i++)
{ matrix_c<TDato>::at(i, 0) = 1;
matrix_c<TDato>::at(i, n + 1) = 1;
}
starting_pos.first = 0;
starting_pos.second = 0;
finishing_pos.first = 0;
finishing_pos.second = 0;
}
template <typename TDato>
board_s<TDato>::~board_s(void){}
template <typename TDato>
pair<int, int> board_s<TDato>::get_start(void) { return starting_pos; }
template <typename TDato>
void board_s<TDato>::file_depiction(void)
{ string line;
int x, y, i;
std::ifstream bd;
bd.open("board_depiction.txt");
if (bd.is_open())
{ getline(bd, line);
getline(bd, line);
i = line.size() - 1;
y = matrix_c<TDato>::strtoi(line, i);
i--;
x = matrix_c<TDato>::strtoi(line, i);
matrix_c<TDato>::resize(x + 2, y + 2);
getline(bd, line);
getline(bd, line);
i = line.size() - 1;
y = matrix_c<TDato>::strtoi(line, i);
i--;
x = matrix_c<TDato>::strtoi(line, i);
object_setter("STARTING POSITION", x, y);
getline(bd, line);
getline(bd, line);
i = line.size() - 1;
y = matrix_c<TDato>::strtoi(line, i);
i--;
x = matrix_c<TDato>::strtoi(line, i);
object_setter("FINISHING POSITION", x, y);
while (getline(bd, line))
if (line[0] != 'O')
{ i = line.size() - 1;
y = matrix_c<TDato>::strtoi(line, i);
i--;
x = matrix_c<TDato>::strtoi(line, i);
object_setter("NEW OBSTACLE", x, y);
}
}
else cout << "ERROR";
}
template <typename TDato>
ostream& board_s<TDato>::write(ostream& os)
{ int temp = matrix_c<TDato>::get_n() - 2 + (4 * (matrix_c<TDato>::get_n() - 2));
os << " ";
for (int i = 1; i < temp; i++)
os << "_";
os << " " << endl << "|";
for (int i = 1; i < matrix_c<TDato>::get_m() - 1; i++)
{ for (int j = 0; j < 2; j++)
{ for (int k = 1; k < matrix_c<TDato>::get_n() - 1; k++)
switch (matrix_c<TDato>::at(i, k))
{ case 1:
os << "████|";
break;
case 2:
if (j == 0)
os << " CC |";
else os << "_CC_|";
break;
case 3:
if (j == 0)
os << " FF |";
else os << "_FF_|";
break;
default:
if (j == 0)
os << " |";
else os << "____|";
}
os << endl;
if (j == 0) os << "|";
}
if (i < matrix_c<TDato>::get_m() - 2) os << "|";
}
os << endl;
return os;
}
template <typename TDato>
int board_s<TDato>::distance(pair<int, int>& pos) const
{ int d = (finishing_pos.first - pos.first) + (finishing_pos.second - pos.second);
if (d < 0) return (d * (-1));
else return d;
}
template <typename TDato>
bool board_s<TDato>::object_setter(string name, int &x, int &y)
{ if((x > 0) && (x < matrix_c<TDato>::get_m() - 1) && (y > 0) && (y < matrix_c<TDato>::get_n() - 1) && (matrix_c<TDato>::at(x, y) == 0))
{ matrix_c<TDato>::at(x, y) = object_identifier(name);
cout << endl << endl << "The " << name << " has been set in (" << x << ", " << y << ")" << endl;
if (name == "STARTING POSITION")
{ starting_pos.first = x;
starting_pos.second = y;
}
else if (name == "FINISHING POSITION")
{ finishing_pos.first = x;
finishing_pos.second = y;
}
return true;
}
else
{ cout << endl << "The coordinates that you intriduced were out of reach or the position wasn't free." << endl;
return false;
}
}
template <typename TDato>
int board_s<TDato>::object_identifier(string &name) const
{ if (name == "NEW OBSTACLE")
return 1;
else if (name == "STARTING POSITION")
return 2;
else if (name == "FINISHING POSITION")
return 3;
else return 0;
}
matrix_c.hpp
#ifndef __MATRIX_C__
#define __MATRIX_C__
#include <cstdio>
#include <iostream>
#include <iomanip>
#include <cstring>
#include "vector_c.hpp"
using namespace std;
template <typename TDato>
class matrix_c //Template matrix class implemented with a vector.
{ private:
int m_;
int n_;
vector_c<TDato> v_;
public:
matrix_c(void); //Empty constructor
matrix_c(int, int); //Constructor with dimensions
~matrix_c(void);
void resize(int, int);
TDato& at (int, int); //Redirects to position (x, y)
virtual TDato& operator()(int, int); //Operator for at(int, int)
int get_m(void) const;
int get_n(void) const;
private:
int pos(int, int);
protected:
int ctoi(char&) const;
int strtoi(string&, int&) const;
};
#endif
matrix_c.cpp
#include "../include/matrix_c.hpp"
using namespace std;
template <typename TDato>
matrix_c<TDato>::matrix_c(void):
m_(0),
n_(0),
v_() {}
template <typename TDato>
matrix_c<TDato>::matrix_c(int m, int n):
m_(m),
n_(n),
v_(m * n) {}
template <typename TDato>
matrix_c<TDato>::~matrix_c(void) {}
template <typename TDato>
void matrix_c<TDato>::resize(int m, int n)
{ v_.resize(m * n);
m_ = m;
n_ = n;
}
template <typename TDato>
TDato& matrix_c<TDato>::at(int i, int j) { return v_[(pos(i,j))]; }
template <typename TDato>
TDato& matrix_c<TDato>::operator()(int i, int j) { return at(i,j); }
template <typename TDato>
int matrix_c<TDato>::get_m(void) const { return m_; }
template <typename TDato>
int matrix_c<TDato>::get_n(void) const { return n_; }
template <typename TDato>
int matrix_c<TDato>::pos(int i, int j) { return ((n_ * i) + j); }
template <typename TDato>
int matrix_c<TDato>::ctoi(char &c) const
{ int n = c;
return n - 48;
}
template <typename TDato>
int matrix_c<TDato>::strtoi(string &s, int& i) const
{ int n = 0;
int mult = 1;
while ((s[i] != ' ') && (i >= 0))
{ n += ctoi(s[i]) * mult;
mult *= 10;
i--;
}
return n;
}
template class matrix_c<int>;
vector_c.hpp
#ifndef __VECTOR_C__
#define __VECTOR_C__
#include <iostream>
#include <cstdio>
#include <cassert>
using namespace std;
template <typename TDato>
class vector_c
{ private:
int sz_;
TDato* data_;
public:
vector_c(void); //Empty constructor
vector_c(int); //Constructor with size
~vector_c(void);
TDato& get_data(int) const;
void set_data(TDato&, int);
ostream& write(ostream&) const;
TDato& operator [](int);
void resize(int);
private:
void new_vector(void);
void del_vector(void);
};
#endif
vector_c.cpp
#include "../include/vector_c.hpp"
#include "../include/node_c.hpp"
using namespace std;
template <typename TDato>
vector_c<TDato>::vector_c(void):
sz_(0),
data_(NULL) {}
template <typename TDato>
vector_c<TDato>::vector_c(int size):
sz_(size),
data_(new TDato[sz_]) {}
template <typename TDato>
vector_c<TDato>::~vector_c(void)
{ delete[] data_;
data_ = NULL;
}
template <typename TDato>
TDato& vector_c<TDato>::get_data(int a) const { return data_[a]; }
template <typename TDato>
void vector_c<TDato>::set_data(TDato& dat, int a) { data_[a] = dat;}
template <typename TDato>
TDato& vector_c<TDato>::operator [](int position) { return get_data(position); }
template <typename TDato>
void vector_c<TDato>::resize(int sz)
{ del_vector();
sz_ = sz;
new_vector();
}
template <typename TDato>
void vector_c<TDato>::new_vector(void){
data_ = new TDato[sz_];
}
template <typename TDato>
void vector_c<TDato>::del_vector(void)
{ if (data_ != NULL){
delete [] data_;
data_ = NULL;
}
}
template class vector_c<int>;
template class vector_c<node_c*>;
node_c.hpp
#define MAX_CHILDREN 4
#ifndef __NODE_C__
#define __NODE_C__
#include <iostream>
#include <cstdio>
#include <cassert>
#include "vector_c.hpp"
using namespace std;
class node_c
{ private:
node_c* parent_;
vector_c< node_c* > children_;
pair<pair<int, int>, int> data_;
public:
node_c(void);
node_c(int &x, int &y, int &cost);
node_c(pair<pair<int, int>, int>&);
~node_c(void);
void add_child(node_c*);
};
#endif
node_c.cpp
#include "../include/node_c.hpp"
using namespace std;
node_c::node_c(void):
parent_(NULL)
{ for (int i = 0; i < MAX_CHILDREN; i++)
children_[i] = NULL;
data_.first.first = 0;
data_.first.second = 0;
data_.second = 0;
}
node_c::node_c(int &x, int &y, int &cost):
parent_(NULL)
{ for (int i = 0; i < MAX_CHILDREN; i++)
children_[i] = NULL;
data_.first.first = x;
data_.first.second = y;
data_.second = cost;
}
node_c::node_c(pair<pair<int, int>, int> &dat):
parent_(NULL),
data_(dat)
{ for (int i = 0; i < MAX_CHILDREN; i++)
children_[i] = NULL;
}
node_c::~node_c(void)
{ parent_ = NULL;
for (int i = 0; i < MAX_CHILDREN; i++)
children_[i] = NULL;
data_.first.first = 0;
data_.first.second = 0;
data_.second = 0;
}
void node_c::add_child(node_c* chld)
{ int i;
for (i = 0; i < MAX_CHILDREN; i++)
{ if (children_[i] == NULL)
break;
}
if (children_[i] != NULL)
{ cout << endl << "You can't add any more children." << endl;
return;
}
else children_[i] = chld;
}
tree_c.hpp
#ifndef __TREE_C__
#define __TREE_C__
#include "node_c.hpp"
using namespace std;
class tree_c
{ private:
node_c* root_;
int depth_;
public:
tree_c(void);
tree_c(node_c*);
node_c* add_node(node_c*, int&, int&, int);
};
#endif
tree_c.cpp
#include "../include/tree_c.hpp"
using namespace std;
tree_c::tree_c(void):
root_(NULL),
depth_(0) {}
tree_c::tree_c(node_c* root):
root_(root),
depth_(1) {}
node_c* tree_c::add_node(node_c* parent, int& x, int& y, int cost)
{ node_c* node = new node_c(x, y, cost);
parent->add_child(node);
}
car_c.hpp
#ifndef __CAR_C__
#define __CAR_C__
#include <iostream>
#include <cstdio>
#include <cassert>
#include "tree_c.hpp"
#include "board_s.hpp"
using namespace std;
class car_c
{ private:
tree_c tree_;
pair<int, int> pos_;
matrix_c<int> visited_;
public:
car_c(void);
car_c(board_s<int>&);
~car_c(void);
};
#endif
car_c.cpp
#include "../include/car_c.hpp"
using namespace std;
car_c::car_c(void):
tree_(NULL)
{ pos_.first = 0;
pos_.second = 0;
}
car_c::car_c(board_s<int>& board):
pos_(board.get_start()),
tree_(tree_.add_node(NULL, pos_.first, pos_.second, 0))
{ visited_(pos_.first, pos_.second) = 1; }
car_c::~car_c(void) {}
Debugging information:
Program received signal SIGSEGV, Segmentation fault.
0x0000000000401cc2 in node_c::node_c (this=0x6187d0, x=#0x7ffffffeddf0: 8, y=#0x7ffffffeddf4: 0,
cost=#0x7ffffffedd2c: 0) at src/node_c.cpp:20
20 children_[i] = NULL;
(gdb) bt
#0 0x0000000000401cc2 in node_c::node_c (this=0x6187d0, x=#0x7ffffffeddf0: 8, y=#0x7ffffffeddf4: 0,
cost=#0x7ffffffedd2c: 0) at src/node_c.cpp:20
#1 0x0000000000402007 in tree_c::add_node (this=0x7ffffffedde0, parent=0x0, x=#0x7ffffffeddf0: 8,
y=#0x7ffffffeddf4: 0, cost=0) at src/tree_c.cpp:16
#2 0x0000000000402df6 in car_c::car_c (this=0x7ffffffedde0, board=...) at src/car_c.cpp:15
#3 0x0000000000401403 in main () at src/main.cpp:11
Sorry for the length of my question, but this is the minimal reproducible example I was able to make. If you know another way to recreate my error, let me know so I can improve this.
Related
Q: How to create ordered pair of strings
I would like some guidance on a program I am working on currently, I have successfully created a pair of integers and handled exception if the user were to enter the same values twice. I am stuck on doing the same process of creating pairs but instead of ints it has to be strings. One suggestion that I have is changing the random generation of ordered pairs with: string empty = ""; myList2[i].setFirst(empty + char('a' + rand() % 26)); myList2[i].setSecond(empty + char('A' + rand() % 26)); Any suggestions in the right direction would be appreciated. Client File: #include <iostream> #include <ctime> #include <cstdlib> #include <exception> #include "orderedpair.h" using namespace std; using namespace cs_pairs; int main() { int num1, num2; OrderedPair<int> myList[10]; srand(static_cast<unsigned>(time(0))); cout << "default value: "; myList[0].print(); cout << endl; for (int i = 0; i < 10; i++) { myList[i].setFirst(rand() % 50); myList[i].setSecond(rand() % 50 + 50); } myList[2] = myList[0] + myList[1]; if (myList[0] < myList[1]) { myList[0].print(); cout << " is less than "; myList[1].print(); cout << endl; } for (int i = 0; i < 10; i++) { myList[i].print(); cout << endl; } cout << "Enter two numbers to use in an OrderedPair. Make sure they are different numbers: "; cin >> num1 >> num2; OrderedPair<int> x; /* use this before you've implemented the exception handling in the class: x.setFirst(num1); x.setSecond(num2); */ /* use this after you've implemented the exception handling in the class: */ try { x.setFirst(num1); x.setSecond(num2); /*if (x.setFirst(num1) == x.setSecond(num2)) { throw OrderedPair<int>::DuplicateMemberError; } */ } catch (OrderedPair<int>::DuplicateMemberError e) { cout << "YOU ENTERED TWO OF THE SAME VALUES!" << endl; x.setFirst(OrderedPair<int>::DEFAULT_VALUE); x.setSecond(OrderedPair<int>::DEFAULT_VALUE); } cout << "The resulting OrderedPair: "; x.print(); cout << endl; } Header File: #ifndef ORDEREDPAIR_H #define ORDEREDPAIR_H #include <iostream> namespace cs_pairs { template <class T> class OrderedPair { public: typedef std::size_t size_type; typedef T value_type; // changed int to T static const int DEFAULT_VALUE = 0; class DuplicateMemberError { }; OrderedPair(T newFirst = DEFAULT_VALUE, T newSecond = DEFAULT_VALUE); void setFirst(T newFirst); void setSecond(T newSecond); T getFirst() const; T getSecond() const; OrderedPair<T> operator+(const OrderedPair<T>& right) const; bool operator<(const OrderedPair<T>& right) const; void print() const; private: T first; T second; }; } #include "orderedpair.cpp" #endif // !ORDEREDPAIR_H Implementation File: #include <iostream> #include <exception> using namespace std; namespace cs_pairs { template <class T> OrderedPair<T>::OrderedPair(T newFirst, T newSecond) { setFirst(newFirst); setSecond(newSecond); } template <class T> void OrderedPair<T>::setFirst(T newFirst) { if ((newFirst == second) && (newFirst != 0)) { throw DuplicateMemberError(); } first = newFirst; } template <class T> void OrderedPair<T>::setSecond(T newSecond) { if ((newSecond == first) && (newSecond != 0)) { throw DuplicateMemberError(); } second = newSecond; } template <class T> T OrderedPair<T>::getFirst() const { return first; } template <class T> T OrderedPair<T>::getSecond() const { return second; } template <class T> OrderedPair<T> OrderedPair<T>::operator+(const OrderedPair<T>& right) const { return OrderedPair(first + right.first, second + right.second); } template <class T> bool OrderedPair<T>::operator<(const OrderedPair<T>& right) const { return first + second < right.first + right.second; } template <class T> void OrderedPair<T>::print() const { std::cout << "(" << first << ", " << second << ")"; } }
To be generic, get rid of static const int DEFAULT_VALUE = 0; Get rid of default constructor which doesn't respect your invariant I would get rid of individual setter which might be problematic when uses together: void swap_order(OrderedPair<int>& op) { const auto first = op.getFirst(); op.setFirst(op.getSecond()); // Oups... throw exception op.setSecond(first); } So: template <class T> class OrderedPair { public: using size_type = std::size_t; using value_type = T; class DuplicateMemberError{}; OrderedPair(const T& newFirst, const T& newSecond) : first(newFirst), second(newSecond) { check(); } const T& getFirst() const { return first; } const T& getSecond() const { return second; } OrderedPair<T> operator+(const OrderedPair<T>& right) const; bool operator<(const OrderedPair<T>& rhs) const; void print() const; private: void check() { if (first == second) throw DuplicateMemberError{}; } private: T first; T second; }; As no longer default constructible, you have to change OrderedPair<int> myList[10]; by std::vector<OrderedPair<int>> myList; /*myList.reserve(10);*/ and generation would be: //const std::string empty; const char lower_alphabet = "abcdefghijklmnopqrstuvwxyz"; // 'a'-'z' is not guaranty to be contiguous (EBCDIC) const char upper_alphabet = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"; // 'A'-'Z' is not guaranty to be contiguous (EBCDIC) for (int i = 0; i < 10; i++) { myList.emplace_back(rand() % 50, rand() % 50 + 50); // myList.emplace_back(empty + char(lower_alphabet[rand() % 26], empty + char(upper_alphabet[rand() % 26]); }
Binary '[': no operator found which takes a left hand operand of type 'const SortableVector<int>'
So I ran into this issue as I was coding for the class I'm currently in, I believe the code should run fine but this came up: Binary '[': no operator found which takes a left hand operand of type 'const SortableVector' I'm not quite sure how to tackle this, any suggestions? I ended up looking at No '==' operator found which takes a left-hand operand of const Type to see if I could find a solution in there however I did not, it seems my issue is stemming from something that I don't personally see. #include <iostream> #include "SortableVector.h" using namespace std; int main() { const int SIZE = 10; SortableVector<int> intTable(SIZE); for (int x = 0; x < SIZE; x++) { int z; cout << "Please enter a number with no decimals: "; cin >> z; intTable[x] = z; } cout << "These values are in intTable:\n"; intTable.print(); intTable.sortInt(intTable, SIZE); cout << "These values in intTable are now sorted: "; intTable.print(); return 0; } //SortableVector.h #include <iostream> #include <cstdlib> #include <memory> #include <vector> using namespace std; struct IndexOutOfRangeException { const int index; IndexOutOfRangeException(int ix) : index(ix) {} }; template<class T> class SortableVector { unique_ptr<T[]> aptr; int vectorSize; public: SortableVector(int); SortableVector(const SortableVector &); int size() const { return vectorSize; } T &operator[](int); void sortInt(SortableVector<int>, int); void print() const; }; template<class T> SortableVector<T>::SortableVector(int s) { vectorSize = s; aptr = make_unique<T[]>(s); for (int count = 0; count < vectorSize; count++) { aptr[count] = T(); } } template<class T> SortableVector<T>::SortableVector(const SortableVector &obj) { vectorSize = obj.vectorSize; aptr = make_unique<T[]>(obj.vectorSize); for (int count = 0; count < vectorSize; count++) { aptr[count] = obj[count]; } } template<class T> T &SortableVector<T>::operator[](int sub) { if (sub < 0 || sub >= vectorSize) { throw IndexOutOfRangeException(sub); return aptr[sub]; } } template<class T> void SortableVector<T>::sortInt(SortableVector<int> x, int z) { int i, j; int temp = 0; for (i = 0; i < z - 1; i++) { for (j = 0; j < z - 1; j++) { if (x[j] > x[j + 1]) { temp = x[j]; x[j] = x[j + 1]; x[j + 1] = temp; } } } } template<class T> void SortableVector<T>::print() const { for (int k = 0; k < vectorSize; k++) { cout << aptr[k] << " "; } cout << endl; }
Your operator[] returns a reference to the element, which will allow people to directly change the element. The problem happens when you try to use the operator on a const object (when you used const references to pass things to functions). This will allow someone to change the object through that reference returned by operator[], which breaks const-correctness and therefore is not allowed. In case you're sill confused, let's say you have some class like this: class Foo { private: int numbers[100]; public: int& operator[](const int & pos) { return numbers[pos]; } }; This works fine for creating an object and using the bracket operator to access the elements. However, when you try to create a const object: const Foo f; You can do something like this: f[3] = 5; operator[] returns a reference, which can be used to directly change the data stored in f. f is declared as const though, so this must not happen and the compiler gives an error. The solution would be to have two versions of operator[], overloaded by their const-ness: class Foo { private: int numbers[100]; public: int& operator[](const int &pos) { return numbers[pos]; } const int& operator[](const int &pos) const { return numbers[pos]; } };
Program triggering a breakpoint
Hey I'm having trouble figuring out what is causing my program to trigger a breakpoint. For school I had to write a class using templates that mimics a java array list, but in c++. My code seems to work when I only use the push method that I have written more than twice in a test. If I try pushing more than two values onto the arraylist, it starts triggering breakpoints. Here's my code: HeaderFile: Arraylist.h #include <string> using namespace std; template<class t> class ArrayList { public: ArrayList(); void push_back(t m); void erase(t m); int size(); string toString(); t& operator[](unsigned int i); private: int currentIndex; int sizeOfArray; t *p; int currentindex; }; ArrayList.cpp #include "ArrayList.h" #include <iostream> using namespace std; template<class t> ArrayList<t>::ArrayList() { p = new t[1]; sizeOfArray = 1; currentIndex = 0; p[currentIndex] = 0; currentIndex++; } template<class t> int ArrayList<t>::size() { return sizeOfArray; } template<class t> void ArrayList<t>::erase(t m) { int location = 0; for (int i = 0; i < currentIndex; i++) { if (p[i] == m) { location = i; } } for (int i = location; i < currentIndex - 1; i++) { p[i] = p[i + 1]; } currentIndex--; } template<class t> void ArrayList<t>::push_back(t m) { if (currentIndex < sizeOfArray-1) { t *temp = new t[sizeOfArray + 1]; sizeOfArray++; for(int i=0;i<sizeOfArray-1;i++){ temp[i] = p[i]; } temp[currentIndex] = m; currentIndex++; sizeOfArray++; delete [] p; t *p = new t[sizeOfArray]; p = temp; delete [] temp; } else { p[currentIndex] = m; currentIndex++; } } template<class t> t& ArrayList<t>::operator[](unsigned int i) { return p[i]; } template<class t> string ArrayList<t>::toString() { string output = ""; for (int i = 0; i < sizeof(p); i++) { output += to_string(p[i]); } return output; } Source.cpp (just using it as a scratchpad for testing) #include "ArrayList.cpp" #include <iostream> using namespace std; int main() { ArrayList<double> list = ArrayList<double>(); list.push_back(1.0); list.push_back(2.0); list.push_back(3.0); //list.push_back(4.0); cout << list.toString(); cin.get(); return 0; } I believe that the problem has something to do with me somehow going out of bounds with one of my array's, but I can't seem to figure it out (perhaps I've just been staring at this assignment for to long). Any help, or suggestions would be much appreciated as always.
Debug Assertion Failed! Expression: is_block_type_valid(header->_block_use). Object wont init and Push error
In advanced, let me thank your for looking at this code for me, because it has been bugging me for a while now and I can't seem to find the issue. Whenever I run it, it doesn't throw any errors within the console, instead it throws this error: Debug Assertion Failed! Program: [Filepath to .exe] File: minkernel\crts\ucrt\src\appcrt\heap\debug_heap.cpp Line 892 Expression: is_block_type_valid(header->_block_use) I've been trying to figure it out, but it just wont work for me. I believe it has something to do with the template types I am passing in, as it only crashes whenever I try to initialize a minHeap object or try my Push method, which I also believe is an issue. Once again, thank you all so much for looking at my code. Main: #include "minHeap.h" #include "Node.h" #include <iostream> using namespace std; int main() { Node<char> A = Node<char>(0, 'A'); Node<char> B = Node<char>(1, 'B'); Node<char> C = Node<char>(2, 'C'); Node<char> D = Node<char>(3, 'D'); minHeap<char> myHeap = minHeap<char>(); //Below doesn't work, something about subscript is not of integrap type //myHeap.push(A.index, A.value); //myHeap.push(B.index, B.value); //myHeap.push(C.index, C.value); //myHeap.push(D.index, D.value); cout << A.index << endl; myHeap.~minHeap(); return 0; } Here is Node.h: #pragma once template<typename T> class Node { public: float index; T value; Node(float indx, T val); ~Node(); }; template<typename T> inline Node<T>::Node(float indx, T val) { index = indx; value = val; } template<typename T> inline Node<T>::~Node() { } And finally, minHeap: #pragma once template<typename T> class minHeap { private: T* arr[100]; int arrSize = 0; void heapifyUp(int indx); void heapifyDown(int indx); int getParent(int indx); int childLeft(int indx); int childRight(int indx); int swap(int indxA, int indxB); public: minHeap(); ~minHeap(); void push(int indx, T val); void pop(); }; template<typename T> inline minHeap<T>::minHeap() { } template<typename T> inline minHeap<T>::~minHeap() { delete[] arr; } template<typename T> inline void minHeap<T>::heapifyUp(int indx) { if (indx <= 0) return; int j = getParent(indx); if (arr[indx] < arr[j]) { int temp = arr[indx]; arr[indx] = arr[j]; arr[j] = temp; } heapifyUp(j); } template<typename T> inline void minHeap<T>::heapifyDown(int indx) { int j; //if no left child if (childLeft(indx) > arrSize - 1) return; //if no right child if (childRight(indx) > arrSize - 1) j = childLeft(indx); //No children else j = (arr[childLeft(indx)] < arr[childRight(indx)]) ? (childLeft(indx)):(childRight(indx)); if (arr[indx] > arr[indx]) { int temp = arr[indx]; arr[indx] = arr[j]; arr[j] = temp; } heapifyDown(j); } template<typename T> inline int minHeap<T>::getParent(int indx) { return (indx - 1) / 2; } template<typename T> inline int minHeap<T>::childLeft(int indx) { return 2 * i + 1; } template<typename T> inline int minHeap<T>::childRight(int indx) { return 2 * i + 2; } template<typename T> inline int minHeap<T>::swap(int indxA, int indxB) { int tempA = arr[indxA]; int tempB = arr[indxB]; arr[indxA] = tempB; arr[indxB] = tempA; return 0; } template<typename T> inline void minHeap<T>::push(int indx, T val) { //Something with Array is broken. Fix it pupper int tempVal = arr[indx]; arr[indx] = val; arrSize += 1; heapifyUp(arrSize - 1); } template<typename T> inline void minHeap<T>::pop() { int temp = arr[0]; arr[0] = arr[arrSize - 1]; arr[arrSize - 1] = nullptr; arrSize -= 1; heapifyDown(0); }
Why are you calling myHeap.~minHeap();? This results in myHeap being destroyed twice, with the second call trying to free memory that has already been freed. This can cause the error you're seeing. You can construct your variables a lot more concisely: Node<char> A(0, 'A'); minHeap<char> myHeap;
How do I interface a merge_sort algorithm to Vector and a user defined dynamic_array? - to_do
I want to take this merge_sort I wrote and put it into a class. Because their is some coupling of the variables, particularly - left, right_begin, right...I want to make these class members. The variables that are local to each function I will leave as local function variables. Also this function will be used for another class I have called dynamic_array which is a bit more efficient than vector. However I want to make it available to the STL vector as well. How do I do this. Do I use inheritance? Do I make the class a composite class of my dynamic_array...If I do this it will not be available to vector though. The Question: How do I make my merge_sort class interface with the STL container Vector and to my own container dynamic_array. This is for an interview preparation. Thank you. Dynamic Array code below(remove old merge_sort cold) Merge Sort Code - to be converted to a class #include <iostream> using namespace std; const int size=8; int scratch[size],array[size]={6,5,3,1,8,7,2,4}; void print_array(int arr[]){ for (int i = 0; i < size; i++) cout << arr[i] << endl;} void flip_if_unordered(int &x, int &y) { if(array[x]>array[y]) { int tmp = array[x]; array[x] = array[y]; array[y] = tmp; } } void merge_algo(int &left, int &right_begin, int &right) { int iter,iter_left=left,iter_right=right_begin; for(iter=left;iter<=right;++iter) { if( (iter_right>right) || ((iter_left < right_begin) && (array[iter_left]<=array[iter_right]))) { scratch[iter]=array[iter_left]; ++iter_left; } else { scratch[iter]=array[iter_right]; ++iter_right; } } for(iter=left;iter<=right;++iter){array[iter]=scratch[iter];} } void merge_recurse(int left,int right) { int left_end=(left+((right-left)/2)); int right_begin=left_end+1; if(((left+1)==right)){flip_if_unordered(left,right);return;} else if ((left==right)){return;} else { merge_recurse(left,left_end); merge_recurse(right_begin,right); merge_algo(left,right_begin,right); } } int main() { merge_recurse(0,(size-1)); print_array(array); return 0; } Dynamic Array #include "c_arclib.cpp" using namespace std; template <class T> class dynamic_array { private: T* array; T* scratch; void merge_recurse(int left, int right) { if(right == left + 1) { return; } else { int i = 0; int length = right-left; int midpoint_distance = length/2; int l = left, r = left + midpoint_distance; merge_recurse(left, left + midpoint_distance); merge_recurse(left + midpoint_distance, right); for(i = 0; i < length; i++) { if((l < (left + midpoint_distance)) && (r == right || array[l] > array[r])) { scratch[i] = array[l]; l++; } else { scratch[i] = array[r]; r++; } } for(i = left; i < right; i++) { array[i] = scratch[i - left]; } } } void quick_recurse(int left, int right) { int l = left, r = right, tmp; int pivot = array[(left + right) / 2]; while (l <= r) { while (array[l] < pivot)l++; while (array[r] > pivot)r--; if (l <= r) { tmp = array[l]; array[l] = array[r]; array[r] = tmp; l++; r--; } } if (left < r)quick_recurse(left, r); if (l < right)quick_recurse(l, right); } public: int size; void rorder(); void order(); void randorder(); dynamic_array(int sizein) { size=sizein; array=new T[size](); } void print_operator(std::ostream &os = cout) const { for (int i = 0; i < size; i++) os << array[i] << endl; } int merge_sort() { scratch = new T[size](); if(scratch != NULL) { merge_recurse(0, size);return 1; } else{return 0;} } void quick_sort() { quick_recurse(0,size); } }; template <class T> void dynamic_array<T>::randorder() { srand(time(NULL)); int *ap; for(ap=array;ap!=array+size;++ap){*ap=rand();} } template <class T> void dynamic_array<T>::order() { int *ap,i=0; for(ap=array;ap!=array+size;++ap) { *ap=i; ++i; } } template <class T> void dynamic_array<T>::rorder() { int *ap,i=size; for(ap=array;ap!=array+size;++ap) { *ap=i; --i; } } template<class T> ostream& operator<<(ostream& stream, dynamic_array<T> const& data) { data.print_operator(stream); return stream; } int main() { dynamic_array<int> d1(10); d1.order(); cout << d1; /* clock_t time_start=clock(); d1.merge_sort(); clock_t time_end=clock(); double result = (double)(time_end - time_start) / CLOCKS_PER_SEC; cout << result; cout << d1; */ }
Just make it a template. You need 2 template parameter, the type of the elements, and the type of the container. Tipp: if you want to use the class "like a function" define the operator () template<class _Item, class _Container> MergeSort { ... operator () (_Container & C); ... } now you can use C[] and to access elemets for any class that defines operator [], and you can use the size() function with any class that has it. You only have to add them to your dynamic_array class, and you can use MergeSort<int, vector<int> > with vectors, and MergeSort<int, dynamic_array<int> > with dynamic arrays.