SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior prog_joined.cpp:25:17 - c++

Question

I am solving the problem-->
Given an array of integers, find out whether there are two distinct indices i and j in the array such that the absolute difference between nums[i] and nums[j] is at most t and the absolute difference between i and j is at most k.
and the error I get is Line 16: Char 17: runtime error: index 3 out of bounds for type 'int [n - 1]' (solution.cpp)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior prog_joined.cpp:25:17
The line 16 is indice[i][j] = abs(i-j);
class Solution {
public:
bool containsNearbyAlmostDuplicate(vector<int>& nums, int k, int t) {
int n = nums.size();
int indice[n-1][n-1];
int total[n-1][n-1];
for(int i = 0;i<n;i++)
{
for(int j=0;j<n;j++)
{
indice[i][j]= abs(i-j);
total[i][j] = abs(nums[i]-nums[j]);
}
}
for(int i = 0;i<n;i++)
{
for(int j=0;j<n;j++)
{
if(indice[i][j]<=k && total[i][j]<=t)
{
return true;
}
}
}
return false;
}
};
for the test case [1,2,3,1] 3 0
The code works fine on my device and other compiler but not on leetcode's compiler.
Please help

Answer 1

This would fix your bug, however there is a problem with your algorithm, does not pass all the test cases:
class Solution {
public:
bool containsNearbyAlmostDuplicate(vector<int>& nums, int k, int t) {
int n = nums.size();
int indice[n][n];
int total[n][n];
for (int i = 0; i < n; i++) {
for (int j = 0; j < n; j++) {
indice[i][j] = abs(i - j);
total[i][j] = abs(nums[i] - nums[j]);
}
}
for (int i = 0; i < n; i++) {
for (int j = 0; j < n; j++) {
if (indice[i][j] <= k && total[i][j] <= t) {
return true;
}
}
}
return false;
}
};
This solution would pass using std::lower_bound:
// The following block might trivially improve the exec time;
// Can be removed;
static const auto __optimize__ = []() {
std::ios::sync_with_stdio(false);
std::cin.tie(NULL);
std::cout.tie(NULL);
return 0;
}();
// Most of headers are already included;
// Can be removed;
#include <cstdint>
#include <vector>
#include <set>
#include <algorithm>
using ValueType = std::int_fast64_t;
static const struct Solution {
static const bool containsNearbyAlmostDuplicate(
const std::vector<int>& nums,
const int k,
const int t
) {
std::set<ValueType> window;
ValueType len = std::size(nums);
for (auto index = 0; index < len; ++index) {
if (index > k && index - k - 1 < len ) {
window.erase(nums[index - k - 1]);
}
const auto it = window.lower_bound((ValueType)nums[index] - t);
if (it != std::cend(window) && *it - nums[index] <= t) {
return true;
}
window.insert(nums[index]);
}
return false;
}
};