Django: field validator and UNIQUE constraint are not applyed - django

Question

I have a Randomisation model with pat field that should be unique and have a specified format.
I defined unique=true and and validators but neither are applyed
For example, FRA-0001 sould be valid and if I try to registered this code twice it should raise an error validation message on my form (but not crash database).
But currently, I can registered FRA for example and if I registered it twice I raise database error UNIQUE contraint failed
models.py
class Randomisation(models.Model):
...
pat = models.CharField("Patient number", max_length=8, unique=True, null=True, blank=True,
validators = [
RegexValidator(
regex='^[A-Z]{3}-[0-9]{4}$',
message= 'L\'identifiant doit être au format XXX-0000',
code='invalid_participant_id'
),
],
)
...
forms.py
class RandomizationEditForm(forms.Form):
def __init__(self, request, *args, **kwargs):
super(RandomizationEditForm, self).__init__(*args, **kwargs)
self.user_country = Pays.objects.get(pay_ide = request.session.get('user_country'))
# self.language = request.session.get('language')
# print(self.language)
self.user_site_type = request.session.get('user_site_type')
PAYS = Pays.options_list(self.user_country,self.user_site_type,'fr')
SEXE = Thesaurus.options_list(2,'fr')
STRATE_1 = Thesaurus.options_list(3,'fr')
STRATE_2 = Thesaurus.options_list(4,'fr')
YES = [(None,''),(0,'Non'),(1,'Oui'),]
self.fields["pat"] = forms.CharField(label = "Numéro patient (XXX-0000)")
self.fields['pat'].widget.attrs.update({
'autocomplete': 'off'
})
self.fields["ran_nai"] = forms.IntegerField(label = "Date de naissance (année)", widget=forms.TextInput)
self.fields['ran_nai'].widget.attrs.update({
'autocomplete': 'off'
})
self.fields["ran_sex"] = forms.ChoiceField(label = "Sexe", widget=forms.Select, choices=SEXE)
self.fields["ran_st1"] = forms.ChoiceField(label = "Gravité de la maladie COVID-19", widget=forms.Select, choices=STRATE_1)
self.fields["ran_bug"] = forms.BooleanField(label = "Recours à la procédure de secours ?", required = False)
self.fields["ran_dem_nom"] = forms.CharField(label = "Nom de la personne qui demande la randomisation", required = False, initial=None)
self.fields['ran_dem_nom'].widget.attrs.update({
'autocomplete': 'off'
})
self.fields["ran_dem_dat"] = forms.DateField(
# input_formats=settings.DATE_INPUT_FORMATS,
label = "Date de la demande",
initial = timezone.now(),
required = False,
)
self.fields['ran_dem_dat'].widget.attrs.update({
'autocomplete': 'off'
})
# def clean_pat(self):
# data = self.cleaned_data['pat']
# if len(data) < 8:
# raise forms.ValidationError("Merci de contrôler la numéro patient")
# return data
def clean_ran_nai(self):
data = self.cleaned_data['ran_nai']
if data > 2003:
raise forms.ValidationError("Merci de contrôler la date de naissance")
return data
def clean_ran_dem_dat(self):
data = self.cleaned_data['ran_dem_dat']
entrydate = datetime.datetime.strptime(str(data), "%Y-%m-%d")
currentdate = datetime.datetime.now()
if entrydate > currentdate:
raise forms.ValidationError("Merci de contrôler la date (postérieure à la date du jour)")
return data
views.py
def randomization_edit(request):
if request.method == "POST":
form = RandomizationEditForm(request, data=request.POST or None)
if form.is_valid():
# Récupération des données permettant la randomisation
randomisation = Randomisation.objects.filter(Q(pay_ide=form.data.get('pay_ide')) & Q(ran_act=1) & Q(ran_st1=form.data.get('ran_st1')) & Q(pat=None)).first()
randomisation.pat = form.cleaned_data['pat']
randomisation.ran_nai = form.data.get('ran_nai')
randomisation.ran_sex = form.data.get('ran_sex')
randomisation.ran_bug = form.cleaned_data['ran_bug']
if form.data.get('ran_dem_nom') == '':
randomisation.ran_dem_nom = None
else:
randomisation.ran_dem_dat = form.data.get('ran_dem_dat')
randomisation.ran_log = request.user.username
randomisation.ran_dat = timezone.now()
randomisation.save()
return redirect('randomization:confirmation', pk = randomisation.pk)
else:
form = RandomizationEditForm(request)
return render(request, 'randomization/edit.html', {'form': form})

Answer 1

You're redefining the pat field as a CharField in your form, so none of the validations you specified on the model apply. You can either rewrite your form to be a ModelForm or add the regex and uniqueness validation into your form.
class RandomizationEditForm(forms.Form):
def __init__(self, *args, **kwargs):
super(RandomizationEditForm, self).__init__(*args, **kwargs)
self.fields["pat"] = forms.CharField(label = "Numéro patient (XXX-0000)", validators=[RegexValidator(
regex='^[A-Z]{3}-[0-9]{4}$',
message= 'L\'identifiant doit être au format XXX-0000',
code='invalid_participant_id'
)])
def clean_pat(self):
data = self.cleaned_data['pat']
if Randomisation.objects.filter(pat=data).exists():
raise forms.ValidationError("L\'identifiant doit être unique")
return data