Passing String argument from c to java using jni - java-native-interface

I am trying to call java method from C, but getting below error
Status after JNI_CreateJavaVM=<0>
restCall method found:: Avinash Kumar
Execution error : file ''
error code: 114, pc=0, call=1, seg=0
114 Attempt to access item beyond bounds of memory (Signal 11)
Target is to send String as an argument from C to Java function.
Below is the code :
#include <jni.h>
#define ENV (*env)
enum eConst
{
MAX_Options = 21 ,
MAX_LREF = 120 ,
PARSING_ERROR = -10 ,
ERROR = -999 ,
EXCEPTION_ERROR = -100 ,
OK = 1 ,
YES = 'Y' ,
NO = 'N'
};
int main()
{
jint jRet;
jstring jszRes;
static JavaVM *jvm = NULL;
static JNIEnv *env = NULL ;
JavaVMInitArgs vm_args;
JavaVMOption options[MAX_Options-1];
int optionCount=0;
options[optionCount++].optionString = "-verbose:jni,class,gc";
char *path="user/work/avikumar/";
char *class_path="user/work/avikumar/";
char path_option[2000]={'\n'};
sprintf(path_option,"-Djava.class.path=%s/MyClass.class:%s/jersey-core-1.19.jar:%s/jersey-client-1.19.jar:%s/javax.ws.rs-api-2.0-m02.jar:.",class_path,path,path,path);
options[optionCount++].optionString = path_option;
options[optionCount++].optionString = "-Xms128m";
options[optionCount++].optionString = "-Xmx512m";
options[optionCount++].optionString = "-Xss8m";
vm_args.options = options;
vm_args.nOptions = optionCount;
vm_args.version = JNI_VERSION_1_6;
vm_args.ignoreUnrecognized = JNI_FALSE;
jRet = JNI_CreateJavaVM(&jvm,(void**)&env,(void*)&vm_args);
printf("Status after JNI_CreateJavaVM=<%d>\n",jRet);
if (jRet < 0)
{
return(-4);
}
if( ENV->EnsureLocalCapacity(env, MAX_LREF) < 0)
{
printf( "\n out of memory. Program terminated\n");
(*jvm)->DestroyJavaVM(jvm);
return(-5);
}
jclass jlocClass;
jlocClass= ENV->FindClass(env, "MyClass");
if (jlocClass == NULL || (*env)->ExceptionOccurred(env))
{
printf("Can not load the main class\n");
return (-6);
}
jmethodID restCall_method;
restCall_method = ENV->GetMethodID(env, jlocClass,"restCall","(Ljava/lang/String;)V");
if( restCall_method == NULL)
{
printf("restCall method not found\n");
return (-7);
}
char *inp = "Avinash Kumar";
printf("restCall method found:: %s\n",inp);
//jstring jstr = (*env)->NewStringUTF(env,inp);
jstring jstr1=(*env)->NewStringUTF(env, "Avinash Kumar");
ENV->CallVoidMethod(env, jlocClass, restCall_method,jstr1);
(*jvm)->DestroyJavaVM(jvm);
return 0;
}
MyClass.java
class MyClass
{
public static void main(String args[])
{
System.out.println("Hello Avinash\n");
}
public void restCall(String inp)
{
System.out.println(inp+ " :: Hello Avinash from restCall\n");
}
}

You can't mix static/non-static context inside JNI. You have two choices.
Static method
restCall_method = ENV->GetStaticMethodID(
env, jlocClass, "restCall", "(Ljava/lang/String;)V");
...
...
...
ENV->CallStaticVoidMethod(env, jlocClass, restCall_method,jstr1);
and, inside Java
public static void restCall(String inp)
or non-static method
jmethodID init = ENV->GetMethodID(env,jlocClass, "<init>", "()V");
jobject obj_MyClass = ENV->NewObject(env,jlocClass, init);
jmethodID restCall_method;
restCall_method = ENV->GetMethodID(env, jlocClass,"restCall","(Ljava/lang/String;)V");
...
...
...
ENV->CallVoidMethod(env, obj_MyClass, restCall_method,jstr1);
and, inside Java
public void restCall(String inp)
In first case, you have to use Static family methods to get id and call target method, in second case, you have to create instance of class and use methods for object based context.

Related

jni lags minecraft on garbage collect

i’m making a dll in c++ that reads fields via jni. after a while whenever the game garbage collects it stutters.
the memory view in visual studio doesn’t show any change in memory usage so i doubt it’s a memory leak.
this is where i assume it’s happening but i cannot see why / how it happens.
how can i figure out what’s causing the garbage collector to take so long?
jobject get_class_loader() {
jclass thread_clazz = env->FindClass("java/lang/Thread");
jmethodID curthread_mid = env->GetStaticMethodID(thread_clazz, "currentThread", "()Ljava/lang/Thread;");
jobject thread = env->CallStaticObjectMethod(thread_clazz, curthread_mid);
jmethodID threadgroup_mid = env->GetMethodID(thread_clazz, "getThreadGroup", "()Ljava/lang/ThreadGroup;");
jclass threadgroup_clazz = env->FindClass("java/lang/ThreadGroup");
jobject threadgroup_obj = env->CallObjectMethod(thread, threadgroup_mid);
jmethodID groupactivecount_mid = env->GetMethodID(threadgroup_clazz, "activeCount", "()I");
jfieldID count_fid = env->GetFieldID(threadgroup_clazz, "nthreads", "I");
jint activeCount = env->GetIntField(threadgroup_obj, count_fid);
jobjectArray arrayD = env->NewObjectArray(activeCount, thread_clazz, NULL);
jmethodID enumerate_mid = env->GetMethodID(threadgroup_clazz, "enumerate", "([Ljava/lang/Thread;)I");
env->CallIntMethod(threadgroup_obj, enumerate_mid, arrayD);
jobject array_elements = env->GetObjectArrayElement(arrayD, 0);
jmethodID threadclassloader = env->GetMethodID(thread_clazz, "getContextClassLoader", "()Ljava/lang/ClassLoader;");
if (threadclassloader != NULL) {
jobject classloader_obj = env->CallObjectMethod(array_elements, threadclassloader);
env->DeleteLocalRef(array_elements);
env->DeleteLocalRef(thread_clazz);
env->DeleteLocalRef(thread);
env->DeleteLocalRef(threadgroup_clazz);
env->DeleteLocalRef(threadgroup_obj);
env->DeleteLocalRef(arrayD);
return classloader_obj;
}
else {
env->DeleteLocalRef(array_elements);
env->DeleteLocalRef(thread_clazz);
env->DeleteLocalRef(thread);
env->DeleteLocalRef(threadgroup_clazz);
env->DeleteLocalRef(threadgroup_obj);
env->DeleteLocalRef(arrayD);
return 0;
}
}
jclass get_object(const char* class_name) {
jclass clazz = env->FindClass("java/lang/Class");
jmethodID class_for_name_method = env->GetStaticMethodID(clazz, "forName", "(Ljava/lang/String;ZLjava/lang/ClassLoader;)Ljava/lang/Class;");
if (class_for_name_method == NULL) {
env->FatalError("Class.forName(String,boolean,java.lang.ClassLoader)java.lang.Class method not found\n");
}
jstring class_to_load = env->NewStringUTF(class_name);
auto class_loader = get_class_loader();
jclass jar_class = (jclass)env->CallStaticObjectMethod(clazz, class_for_name_method, class_to_load, true, class_loader);
env->ReleaseStringUTFChars(class_to_load, NULL);
env->DeleteLocalRef(class_to_load);
env->DeleteLocalRef(clazz);
env->DeleteLocalRef(class_loader);
return jar_class;
}
instance = std::make_unique<c_minecraft>();
auto minecraft_inst = instance->get_minecraft();
if (!minecraft_inst) {
env->DeleteLocalRef(minecraft_inst);
return;
} // do field suff after here. once done that delete local reference of minecraft_inst

How to Pass and return Array of properties in jni (java to c++) as well as (c++ to java)

How to Pass and return Array of properties in jni (java to c++) as well as (c++ to java)
import java.util.*;
public class Test {
public native static Properties[] getStudentDetails();
public static void main(String[] args) {
System.loadLibrary("Sample");
int a= 10;
Properties[] records = getStudentDetails();
for(Properties record:records){
System.out.print("\ntype:"+record.getProperty("type"));
System.out.print("\ttime:"+record.getProperty("time"));
System.out.print("\tsource:"+record.getProperty("source"));
System.out.print("\teid:"+record.getProperty("eid"));
System.out.println("");
}
}
}
it give me error
Assuming you have access to a std::vector<SearchRecord*> searchRecordResult somewhere:
extern "C"
JNIEXPORT jobjectArray JNICALL Java_Test_getStudentDetails(JNIEnv *env, jclass cls) {
// Get Properties class, its constructor and the put method
jclass cls_Properties = env->FindClass("java/util/Properties");
jmethodID mid_Properties_ctor = env->GetMethodID(cls_Properties, "<init>", "()V");
jmethodID mid_Properties_put = env->GetMethodID(cls_Properties, "put", "(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;");
// Construct the key Strings up front
jstring key_type = env->NewStringUTF("type");
jstring key_time = env->NewStringUTF("time");
jstring key_source = env->NewStringUTF("source");
jstring key_eid = env->NewStringUTF("eid");
jobjectArray ret = env->NewObjectArray(searchRecordResult.size(), cls_Properties, 0);
for (int i = 0; i < searchRecordResult.size(); i++) {
auto result = searchRecordResult[i];
// Allocate and fill a Properties object, making sure to clean up the value Strings.
env->PushLocalFrame(5);
jobject prop = env->NewObject(cls_Properties, mid_Properties_ctor);
env->CallObjectMethod(prop, mid_Properties_put, key_type, env->NewStringUTF(result->type));
env->CallObjectMethod(prop, mid_Properties_put, key_time, env->NewStringUTF(result->time));
env->CallObjectMethod(prop, mid_Properties_put, key_source, env->NewStringUTF(result->source));
env->CallObjectMethod(prop, mid_Properties_put, key_eid, env->NewStringUTF(result->eid));
prop = env->PopLocalFrame(prop);
env->SetObjectArrayElement(ret, i, prop);
}
return ret;
}
The core loop just constructs Properties objects, fills their properties with put and assigns them to the right slot on the ret array.

Passing a list/arraylist of reference type objects contained in a class to JNI/C++

I wrote a piece of code that manipulates reference type objects contained inside a class, now am having trouble while converting this instance to a list of objects.
Here is the code snippet;
classes.java
=================
public class Leg {
public int id;
public String name;
// a few other primitive data types
....
}
public class Line {
public int id;
....
//public Leg mLeg; this worked well
public List<Leg> mLegList;
}
Driver.java
============
public native void setLine(Line jobj);
Line line = new Line();
line.id =200;
line.mLegList = new ArrayList<Leg>(1); // using only one for brevity
Leg obj = new Leg(200, "test", ...);
line.mLegList.add(obj);
Native CPP function
==================
JNIEXPORT void JNICALL Java_Driver_setLine (JNIEnv * env, jobject jobj1, jobject jobj)
{
jclass cls = env->GetObjectClass(jobj);
if (cls == NULL)
return;
jmethodID ctorID = env->GetMethodID(cls, "<init>","()V");
if (!ctorID)
return ;
// I did for one instance like this
/*************************************************************
* jfieldID fid_legID = env->GetFieldID(cls, "mLeg", "LLeg;");
* if (!fid_legID)
* return;
* jobject legObject = env->GetObjectField(jobj, fid_legID);
* jclass clsObject = env->GetObjectClass(legObject);
* if (clsObject) {
* // Get all fields of Leg inside Line ....
*************************************************************/
// Now as i changed it to list/arraylist of Legs, it isn't Working
jfieldID fid_legID = env->GetFieldID(cls, "mLegList", "[LLeg;");
if (!fid_legID)
env->ExceptionDescribe();
// Exception in thread "main" java.lang.NoSuchFieldError: mLegList
}
My questions are:
how to make it working with a list/ArrayList here. I need to
retrieve a set of fields contained in this list.
Why isn't the
native function signature included jobjectarray (or something similar
for jobj1?) Is that causing issues? Thanks for reading the post.
Update
I was able to construct the object successfully as using Arraylist/List require to use
fieldID fid_legID = env->GetFieldID(cls, "mLegList", "Ljava/util/List;");
instead. but now I'm wondering how to iterate through this list and read through all the fields.
Let's say your source code tree looks like this
|-- c
| `-- Driver.c
|-- lib
|-- mypackage
| |-- Driver.java
| |-- Leg.java
| `-- Line.java
`-- target
and then, you have following files:
mypackage/Driver.java
package mypackage;
import java.util.ArrayList;
public class Driver {
static {
System.loadLibrary("Driver");
}
public void list(ArrayList<Leg> list) {
}
public native void setLine(Line line);
public static void main(String [] arg) {
Driver d = new Driver();
Line line = new Line();
line.id = 200;
line.mLegList = new ArrayList<Leg>(1);
Leg obj_1 = new Leg(200, "test_1");
Leg obj_2 = new Leg(300, "test_2");
Leg obj_3 = new Leg(400, "test_2");
line.mLegList.add(obj_1);
line.mLegList.add(obj_2);
line.mLegList.add(obj_3);
d.setLine( line );
}
}
mypackage/Leg.java
package mypackage;
class Leg {
public int id;
public String name;
public Leg(int id, String name) {
this.id = id;
this.name = name;
}
}
mypackage/Line.java
package mypackage;
import java.util.List;
public class Line {
public int id;
public List<Leg> mLegList;
}
You can access elements of the List following way
c/Driver.c
#include "mypackage_Driver.h"
JNIEXPORT void JNICALL Java_mypackage_Driver_setLine(JNIEnv * env, jobject jobj, jobject line)
{
jclass cls_Line = (*env)->GetObjectClass (env, line);
jfieldID fid_mLegList = (*env)->GetFieldID (env, cls_Line, "mLegList", "Ljava/util/List;");
jobject list = (*env)->GetObjectField (env, line, fid_mLegList);
jclass cls_list = (*env)->GetObjectClass (env, list);
int listSize = (*env)->GetArrayLength (env, list);
for (int i = 0; i < listSize; i++) {
jmethodID midGet = (*env)->GetMethodID (env, cls_list, "get",
"(I)Ljava/lang/Object;");
jstring obj = (*env)->CallObjectMethod (env, list, midGet, i);
jclass cls_Leg = (*env)->GetObjectClass(env, obj);
jfieldID fid_name = (*env)->GetFieldID( env, cls_Leg, "name",
"Ljava/lang/String;");
jobject name = (*env)->GetObjectField (env, obj, fid_name);
const char *c_string = (*env)->GetStringUTFChars (env, name, 0);
printf ("[value] = %s\n", c_string);
(*env)->ReleaseStringUTFChars (env, obj, c_string);
}
}
If you want to compile all the stuff, you can use following script
#!/bin/bash
mkdir -p target
mkdir -p lib
ARCH=`uname -s | tr '[:upper:]' '[:lower:]'`
EXT=
if [[ "${ARCH}" == "darwin" ]]; then
EXT=dylib
else
EXT=so
fi
echo $ARCH
javac -h c -d target mypackage/*.java
cc -g -shared -fpic -I${JAVA_HOME}/include -I${JAVA_HOME}/include/${ARCH} c/Driver.c -o lib/libDriver.${EXT}
${JAVA_HOME}/bin/java -Djava.library.path=${LD_LIBRARY_PATH}:./lib -cp target mypackage.Driver
Once you run it, you will get what you are looking for :)
> ./compile.sh
darwin
[value] = test_1
[value] = test_2
[value] = test_2
Have fun with JNI :)
Update
accessing array elements using get method: recipeNo067
accessing array elements using Iterator: recipeNo068
passing ArrayList as Object []: recipeNo069
Usage
> git clone https://github.com/mkowsiak/jnicookbook.git
> export JAVA_HOME=your_JDK_installation
> cd jnicookbook/recipes/recipeNo067
> make
> make test
Iterating across a List in JNI is the same as in Java, it is just more typing.
jobject list = env->GetObjectField(line, fid_legID);
// Iterator iterator = list.iterator();
jclass cls_List = env->FindClass("java/util/List");
jmethodID mid_List_iterator = env->GetMethodID(cls_List, "iterator", "()Ljava/util/Iterator;");
jobject iterator = env->CallObjectMethod(list, mid_List_iterator);
jclass cls_Iterator = env->FindClass("java/util/Iterator");
jmethodID mid_Iterator_hasNext = env->GetMethodID(cls_Iterator, "hasNext", "()Z");
jmethodID mid_Iterator_next = env->GetMethodID(cls_Iterator, "next", "()Ljava/lang/Object");
while (true) {
// if !iterator.hasNext() break
jboolean hasNext = env->CallBooleanMethod(iterator, mid_Iterator_hasNext);
if (!hasNext)
break;
jobject v = env->CallObjectMethod(iterator, mid_Iterator_next);
// Do something with `v`
// Avoid overflowing the local reference table if legList gets large
env->DeleteLocalRef(v);
}
Note that this example still needs error checking.

Jni C++ findclass function return null

I found a problem with jni about C calling Java code.
Environment WIN10 JDK1.8
Currently I need C++ code to call Java code. At first I wrote a demothat was successful. Code show as below:
public class Sample2 {
public String name;
public static String sayHello(String name) {
return "Hello, " + name + "!";
}
public String sayHello() {
return "Hello, " + name + "!";
}
}
Some of the C++ code is as follows:
int main(){
printf("hello world");
JavaVMOption options[3];
JNIEnv* env;
JavaVM* jvm;
JavaVMInitArgs vm_args;
long status;
jclass cls;
jmethodID mid;
jfieldID fid;
jobject obj;
char opt1[] = "-Djava.compiler=NONE";
char opt2[] = "-Djava.class.path=.";
char opt3[] = "-verbose:NONE";
options[0].optionString = opt1; options[0].extraInfo = NULL;
options[1].optionString = opt2; options[1].extraInfo = NULL;
options[2].optionString = opt3; options[2].extraInfo = NULL;
memset(&vm_args, 0, sizeof(vm_args));
vm_args.version = JNI_VERSION_1_8;
vm_args.nOptions = 1;
vm_args.options = options;
vm_args.ignoreUnrecognized = 0;
// 启动虚拟机
status = JNI_CreateJavaVM(&jvm, (void**)& env, &vm_args);
if (status != JNI_ERR){
// 先获得class对象
cls = env->FindClass("Sample2");
}
}
I used Eclipse to compile the Java code into a .class file, copy the .class file into my C++ project, the above DEMO C++ call Java function is successful, and the findclass function returns to normal.
Because I have to introduce a third-party JAR package org.eclipse.paho.client.mqttv3-1.2.0.jar in my own Java, based on the above example, I modified the Java code in DEMO, but when I want to reference the JAR package function, And then run successfully in Eclipse, when I copy the .class file to the C++ project. JNI_CreateJavaVM in the C++ code is returned successfully, but FINDCLASS always returns null, I don't know why. I have not changed the other parts code.
Some Java code:
import javax.net.ssl.TrustManager;
import javax.net.ssl.X509TrustManager;
import org.eclipse.paho.client.mqttv3.*;
import org.eclipse.paho.client.mqttv3.persist.MemoryPersistence;
public class Sample2 {
public String name;
static MqttAsyncClient mqttClient = null;
static String username = "xxx";
static String password = "xxx";
static String broker = "xxx";
public static void main(String[] args) throws InterruptedException {
System.out.print("hello");
}
public static void start() {
String clientId = "mqttserver" + String.valueOf(System.currentTimeMillis());
try {
mqttClient = new MqttAsyncClient(broker, clientId, new MemoryPersistence());
} catch (Exception me) {
me.printStackTrace();
}
}
When in start function is added
mqttClient = new MqttAsyncClient(broker, clientId, new MemoryPersistence()); After the code, there will be problems
Take a look here
char opt1[] = "-Djava.compiler=NONE";
char opt2[] = "-Djava.class.path=.";
char opt3[] = "-verbose:NONE";
options[0].optionString = opt1; options[0].extraInfo = NULL;
options[1].optionString = opt2; options[1].extraInfo = NULL;
options[2].optionString = opt3; options[2].extraInfo = NULL;
memset(&vm_args, 0, sizeof(vm_args));
vm_args.version = JNI_VERSION_1_8;
vm_args.nOptions = 1;
You are passing three options (array of options with three options defined) but then, you say something like this
vm_args.nOptions = 1;
which means you are passing just one option. It means your options
char opt2[] = "-Djava.class.path=.";
char opt3[] = "-verbose:NONE";
are not even read. You have to change your code to
vm_args.nOptions = 3;
Also, make sure to put on java.class.path all the JARs, folders, where classes required by your code are.

FindClass returns null

I'm having problems with my FindClass call which returns null:
JData::JIgZorroBridgeClass = env->FindClass(JData::IgZorroBridgePath);
Most answers I find about this points to missing package name, or class loader issues.
IgZorroBridgePath here is my class with fully qualified package name, ie. com/igz/Zorro.
Also as you can see I'm initializing the JVM right before this FindClass call, so I think I should be on the correct thread already.
Is there anything else I can check?
#include <assert.h>
#include "JNIHandler.hpp"
#include "JReferences.hpp"
const char* JVMClassPathOption = "-Djava.class.path=Plugin/ig/igplugin-0.1.jar";
const char* IgZorroBridgePath = "com/danlind/igz/ZorroBridge";
void JNIHandler::init()
{
initializeJVM();
initializeJavaReferences();
}
void JNIHandler::initializeJVM()
{
if(isJVMLoaded) return;
JavaVMInitArgs args;
JavaVMOption options[1];
args.version = JData::JNI_VERSION;
args.nOptions = 1;
args.options = options;
options[0].optionString = (char*)JData::JVMClassPathOption;
args.ignoreUnrecognized = JNI_FALSE;
jint res = JNI_CreateJavaVM(&jvm, (void **)&env, &args);
assert(res == JNI_OK);
isJVMLoaded = true;
}
JNIEnv* JNIHandler::getJNIEnvironment(){
return env;
}
JNIEnv* JNIHandler::getEnvForCurrentThread()
{
int envStat = jvm->GetEnv((void **)&env, JData::JNI_VERSION);
if (envStat == JNI_EDETACHED) {
jint res = jvm->AttachCurrentThread((void**)&env, NULL);
assert (res == JNI_OK);
}
return env;
}
void JNIHandler::initializeJavaReferences()
{
if(areJavaReferencesInitialized) return;
initExceptionHandling();
initBridgeObject();
registerNatives();
areJavaReferencesInitialized = true;
}
void JNIHandler::initBridgeObject()
{
JData::JIgZorroBridgeClass = env->FindClass(JData::IgZorroBridgePath);
checkJNIExcpetion(env);
registerClassMethods();
JData::JIgZorroBridgeObject = env->NewObject(JData::JIgZorroBridgeClass, JData::constructor.methodID);
checkJNIExcpetion(env);
}
void JNIHandler::initExceptionHandling()
{
JData::ExceptionClass = env->FindClass(JData::ExcPath);
JData::excGetName.methodID = env->GetMethodID(JData::ExceptionClass, JData::excGetName.name, JData::excGetName.signature);
}
void JNIHandler::registerNatives()
{
JData::JZorroClass = env->FindClass(JData::ZorroPath);
env->RegisterNatives(JData::JZorroClass, JData::nativesTable, JData::nativesTableSize);
checkJNIExcpetion(env);
}
void JNIHandler::registerClassMethods()
{
for(auto *desc : JData::igZorroBridgeMethods)
{
desc->methodID = env->GetMethodID(JData::JIgZorroBridgeClass, desc->name, desc->signature);
checkJNIExcpetion(env);
}
}
void JNIHandler::checkJNIExcpetion(JNIEnv* env)
{
jthrowable exc = env->ExceptionOccurred();
if (!exc) return;
jclass exccls(env->GetObjectClass(exc));
jstring name = static_cast<jstring>(env->CallObjectMethod(exccls, JData::excGetName.methodID));
char const* utfName(env->GetStringUTFChars(name, 0));
JData::excGetMessage.methodID = env->GetMethodID(exccls, JData::excGetMessage.name, JData::excGetMessage.signature);
jstring message = static_cast<jstring>(env->CallObjectMethod(exc, JData::excGetMessage.methodID));
char const* utfMessage(env->GetStringUTFChars(message, 0));
BrokerError(utfName);
BrokerError(utfMessage);
env->ReleaseStringUTFChars(message, utfMessage);
env->ReleaseStringUTFChars(name, utfName);
env->ExceptionClear();
}
I was using the spring boot maven plugin, which reshuffles the package structure. I switched to using the shade plugin instead, which doesn't move packages around. This enabled FindClass to find my java class.