user login redirect always to homepage - django

Question

I am creating alogin view in which when user is not none then logged in it should go to same page before login , then also go to other url , but it always goes to the other url though it should go to first redirect
views.py
def login_page(request):
form = LoginForm(request.POST or None)
context = {
"form": form
}
next_get_url= request.GET.get('next')
next_post_url= request.POST.get('next')
redirect_path = next_get_url or next_post_url or None
if form.is_valid():
print(form.cleaned_data)
username = form.cleaned_data.get("username")
password = form.cleaned_data.get("password")
user = authenticate(request, username=username, password=password)
print(user)
if user is not None:
login(request, user)
if is_safe_url(redirect_path, request.get_host()):
return(redirect(redirect_path))
else:
return (redirect('/'))
else:
print ("Error")
return render(request, "accounts/login.html",context)
forms.py:
class LoginForm(forms.Form):
username = forms.CharField()
password = forms.CharField(widget=forms.PasswordInput)
i mean it always go to this case:
else:
return (redirect('/'))
whenever this is the case:
if is_safe_url(redirect_path, request.get_host()):
return(redirect(redirect_path))
all tries and solutions found did not solve this any help! and thanks in advance

Answer 1

Firstly, Django comes with a LoginView that handles the redirect for you. it would be better to use that than write your own view.
If you do write your own view, then you need to include your redirect_path in your context dictionary here is where Django does is, and then you need to include it as a hidden field in the login form (see the example template in the docs for LoginView:
<form ...>
...
<input type="submit" value="login">
<input type="hidden" name="next" value="{{ next }}">
</form>

Answer 2

You should use
redirect_path = next_get_url or next_post_url or "/"
because if you pass None to is_safe_url, it will return False as it only takes valid urls.

Answer 3

try a render methodes li this
def my_view(request):
username = request.POST['username']
password = request.POST['password']
user = authenticate(request, username=username, password=password)
if user is not None:
login(request, user)
# Redirect to a success page.
render(request , 'bootstrap/page_learn.html')
else:
# Return an 'invalid login' error message.
render(request , 'bootstrap/page_learn.html')