How to use QMutex properly in derived classes? - c++

Question

I have the following classes (simplified) :
class BaseJob : public QObject
{
Q_OBJECT
public:
QMutex *getMutex() const {
return &mutex;
}
virtual ~BaseJob() = 0;
private:
static QMutex mutex;
};
class Worker1 : public QObject
{
Q_OBJECT
public:
Worker1(QMutex *mutex) : m_mutex(mutex) {}
public slots:
void work() {
QMutexLocker lock(m_mutex);
qInfo() << "worker1 is running";
}
private:
QMutex *m_mutex;
};
class Worker2 : public QObject
{
Q_OBJECT
public:
Worker2(QMutex *mutex) : m_mutex(mutex) {}
public slots:
void work() {
QMutexLocker lock(m_mutex);
qInfo() << "worker2 is running";
}
private:
QMutex *m_mutex;
};
class Job1 : public BaseJob
{
Q_OBJECT
public:
Job1() : m_worker(new Worker1(this->getMutex())) {
connect(this, SIGNAL(doWork()),
m_worker, SLOT(work()));
connect(&m_thread, SIGNAL(finished()),
m_worker, SLOT(deleteLater()));
m_worker->moveToThread(&m_thread);
m_thread.start();
}
void work() {
emit doWork();
}
virtual ~Job1() {
m_thread.quit();
m_thread.wait();
}
signals:
void doWork();
private:
QThread m_thread;
Worker1 *m_worker;
};
class Job2 : public BaseJob
{
Q_OBJECT
public:
Job2() : m_worker(new Worker2(this->getMutex())) {
connect(this, SIGNAL(doWork()),
m_worker, SLOT(work()));
connect(&m_thread, SIGNAL(finished()),
m_worker, SLOT(deleteLater()));
m_worker->moveToThread(&m_thread);
m_thread.start();
}
void work() {
emit doWork();
}
virtual ~Job2() {
m_thread.quit();
m_thread.wait();
}
signals:
void doWork();
private:
QThread m_thread;
Worker2 *m_worker;
};
and then i call the jobs using :
void Widget::on_pushButton_clicked()
{
m_job1->work();
m_job2->work();
}
Workers need to have a public slot, work() that should be protected by a critical section to prevent concurrent write access to the same file.
So far, i have added a QMutex in the base class BaseJob so i can pass a reference to this mutex, through Worker1 and Worker2 ctor and finally inside work() function.
And it works but is there a better approach to achieve this ?
Thanks.