How to exit this TicTacToe Game loop? [closed] - c++

Question

Closed. This question needs debugging details. It is not currently accepting answers.
Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.
Closed 5 years ago.
Improve this question
I am trying to make a TicTacToe Game, but something isn't working in my code. I made a new class called TicTacToeGame and I have my source.cpp (main file). Everything was fine until I made a loop to test if a space is occupied.
Since then, it asks me to enter a coordinate for X. I give it an answer and then it asks me for a Y coordinate. I give it an answer; but, again it asks for a Y coordinate, and if I give him a bad input it start spamming me with that question or tells me that I've introduced a bad input.
What can I do? I want to know what's wrong.
TicTacToeGame.h
#pragma once
class TicTacToeGame
{
public:
TicTacToeGame();
void playGame();
private:
bool placeMarker(int x, int y, char currentPlayer);
int getXCoord();
int getYCoord();
char board[3][3];
// Clears the board
void clearBoard();
// Prints the board
void printBoard();
};
TicTacToe.cpp
#include "TicTacToeGame.h"
#include <iostream>
using namespace std;
TicTacToeGame::TicTacToeGame()
{
clearBoard();
};
void TicTacToeGame::playGame()
{
char player1 = 'X';
char player2 = 'Y';
char currentPlayer = 'X';
bool isDone = false;
int x, y;
while (isDone == false) {
printBoard();
x = getXCoord();
y = getYCoord();
if (placeMarker(x, y, currentPlayer) == false) {
cout << "That spot is occupied\n";
}
else
{
// Switch player so every player can put markers
if (currentPlayer == player1) {
currentPlayer = player2;
}
else
{
currentPlayer = player1;
}
}
}
}
int TicTacToeGame::getXCoord()
{
bool isInputBad = true;
int x;
while (isInputBad == true) {
cout << "Enter the X coordinate: ";
cin >> x;
if (x < 1 || x > 3) {
cout << "Invalid coordinate!\n";
}
else
{
isInputBad = false;
}
}
return x - 1;
}
int TicTacToeGame::getYCoord()
{
bool isInputBad = true;
int y;
while (isInputBad == true) {
cout << "Enter the Y coordinate: ";
cin >> y;
}
if (y < 1 || y > 3) {
cout << "Invalid coordinate!\n";
}
else
{
isInputBad = false;
}
return y - 1;
}
bool TicTacToeGame::placeMarker(int x, int y, char currentPlayer)
{
if (board[y][x] != ' ') {
return false;
}
board[y][x] = currentPlayer;
return true;
}
void TicTacToeGame::clearBoard()
{
for (int i = 0; i < 3; i++) {
for (int j = 0; j < 3; j++) {
board[i][j] = ' ';
}
}
}
void TicTacToeGame::printBoard()
{
cout << endl;
cout << " |1 2 3|\n";
for (int i = 0; i < 3; i++) {
cout << "--------\n";
cout << i+1 << "|" << board[i][0] << "|" << board[i][1] << "|" << board[i][2] << "|\n";
}
cout << "--------\n";
}
source.cpp
#include "TicTacToeGame.h"
#include <iostream>
using namespace std;
int main()
{
TicTacToeGame game;
game.playGame();
system("PAUSE");
return 0;
}

Answer 1

Your while loop will never exit,
The X Coord While Loop:
while (isInputBad == true) {
cout << "Enter the X coordinate: ";
cin >> x;
if (x < 1 || x > 3) {
cout << "Invalid coordinate!\n";
}
else
{
isInputBad = false;
}
} // end of while loop
The Y Coord While loop:
while (isInputBad == true) {
cout << "Enter the Y coordinate: ";
cin >> y;
} // end of while loop
if (y < 1 || y > 3) {
cout << "Invalid coordinate!\n";
}
else
{
isInputBad = false;
}
See how the validation code is outside of the while loop for the Y Coord?
The while condition isInputBad will always equal true because it would get set to false after the loop.
Move the end of the while loop after the if statement and it should work.