JUnit failure when mocking Logger - unit-testing

Question

My class to be tested is of HostApi with the static logger.
public class HostApi {
String baseUrl;
private static Logger logger=LogFactory.getLogger(HostApi.class);
/**
* Constructor
*
* #param baseUrl
* - protocol + "://" + dockerIp + ":" + dockerPort Example -
* http://192.168.99.100:2375
*/
public HostApi(String baseUrl) {
this.baseUrl = baseUrl;
}
HostRestClient client;
public Container getContainerInfo(String containerId) throws IOException, AgentException {
logger.debug("############# getContainerInfo start ###################"); //$NON-NLS-1$
String output;
String path = "/containers/" + containerId + "/json"; //$NON-NLS-1$ //$NON-NLS-2$
client = new HostRestClient();
output = client.processGetRequest(baseUrl + path);
logger.trace(output);
ObjectMapper mapper = new ObjectMapper();
Container container = mapper.readValue(output, Container.class);
logger.debug("############# getContainerInfo end ###################\n\n"); //$NON-NLS-1$
return container;
}
}
My JUnit test class is HostApiTest
#RunWith(PowerMockRunner.class)
#PrepareForTest({HostApi.class,ObjectMapper.class,LogFactory.class})
public class HostApiTest {
HostApi hp;
static Logger logger;
#BeforeClass
public static void before()
{
System.out.println("Before Class");
}
#AfterClass
public static void after() {
System.out.println("After Class");
}
#Mock
Logger loggermock;
#Before()
public void setUp() {
mockStatic(LogFactory.class);
EasyMock.expect(LogFactory.getLogger(HostApi.class)).andReturn(loggermock );
//logger=createMock(Logger.class);
// Whitebox.setInternalState(HostApi.class, logger);
hp=new HostApi("skj"); //$NON-NLS-1$
}
#Test
public void testgetContainerInfo() throws Exception{
System.out.println("abc");
HostRestClient client=PowerMock.createMock(HostRestClient.class);
ObjectMapper obj=PowerMock.createMock(ObjectMapper.class);
Container container=new Container();
container.setId("234");
String containerData=container.toString();
PowerMock.expectNew(ObjectMapper.class).andReturn(obj);
PowerMock.expectNew(HostRestClient.class).andReturn(client);
EasyMock.expect(client.processGetRequest(EasyMock.isA(String.class))).andReturn(containerData);
EasyMock.expect(obj.readValue(EasyMock.isA(String.class),EasyMock.same(Container.class))).andReturn(container);
replayAll();
assertEquals("234",hp.getContainerInfo("25").getId());
EasyMock.verify();
}
}
Without the logger in the code (i.e. commenting out in HostApi) it works, however after adding logger it throws assertion error
I added static mocking of logfactory however it does not seem to work.
What is it that I am doing wrong in mocking? I can only use powermock.

Answer 1

Remove ...
LogFactory.class from the #PrepareForTest({...}) annotation
#Mock Logger loggermock; from HostApiTest
mockStatic(LogFactory.class); from HostApiTest
EasyMock.expect(LogFactory.getLogger(HostApi.class)).andReturn(loggermock); from HostApiTest
Your test case has no expectations or assertions on the behaviour of the HostApi's logger so there is no need to mock it.