C++ System Call Thread - c++

Question

Hello I am trying to write a program that will create a thread in which it will system call the char buffer. I am new to threads and I am having a hard time to get the thread working.
Most of this stuff I got is from just searching in gooogle and watching videos.
Here is what I have so far.
#define BUFFERSIZE 25
DWORD WINAPI ThreadFunc(LPVOID param);
int main()
{
while (1)
{
char buffer[BUFFERSIZE];
DWORD threadID;
HANDLE ThreadHandle;
fgets(buffer,BUFFERSIZE,stdin);
if (buffer == "dir")
{
ThreadHandle = CreateThread(NULL, 0,ThreadFunc, &buffer, 0, &threadID);
}
else if (buffer == "help")
{
}
else if (buffer == "vol")
{
}
else if (buffer == "path")
{
}
else if (buffer == "tasklist")
{
}
else if (buffer == "notepad")
{
}
else if (buffer == "echo")
{
}
else if (buffer == "color")
{
}
else
{
}
}
}
DWORD WINAPI ThreadFunc(LPVOID param)
{
char* value = (char*)param;
system(value);
return 0;
}

Answer 1

There are few problems with your code:
1. As Daniel pointed out, incorrect parameter to CreateThread (buffer). You use wrong type and scope of the variable.
2. Expressions in your if statements will be always evaluated to false. Types like char * don't have overloaded operators and == will result to pointer comparison.
#define BUFFERSIZE 25
DWORD WINAPI ThreadFunc(LPVOID param);
int main()
{
while (1)
{
char* buffer = new char [BUFFERSIZE];
DWORD threadID;
HANDLE ThreadHandle;
fgets(buffer,BUFFERSIZE,stdin);
if (strcmp(buffer, "dir") == 0)
{
ThreadHandle = CreateThread(NULL, 0,ThreadFunc, buffer, 0, &threadID);
}
else if(...) // next
{
}
else
{
delete[] buffer;
}
}
}
DWORD WINAPI ThreadFunc(LPVOID param)
{
char* value = (char*)param;
system(value);
delete[] value;
return 0;
}

Answer 2

There seems to be two mistakes:
First
ThreadHandle = CreateThread(NULL, 0,ThreadFunc, &buffer, 0, &threadID)
Should be
ThreadHandle = CreateThread(NULL, 0,ThreadFunc, buffer, 0, &threadID)
Notice that the buffer lost it's & since the name of an array is already a pointer to it.
Second
Your main thread exits right after running the second thread.
Sadly, as soon as the main thread exists the process is terminated, so nothing happens. Try adding a sleep in your main thread.