Beginner C++ - Having trouble compiling my code [closed] - c++

Question

Closed. This question does not meet Stack Overflow guidelines. It is not currently accepting answers.
Closed 5 years ago.
Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.
This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.
Improve this question
EDIT: Working code below
I'll paste my code below, but if someone could please explain to me why what's happening is happening instead of simply writing me out an answer, that'd be much appreciated, thank you!
Im having a compilation error, telling me there is no instance of overloaded function. I can circumvent this compilation error by commenting out the line cin.get(Kingdom.m_name, 32, '\n');, but this is obviously useless, because now my program just terminates after entering the name of the first Kingdom.
I assume the line void read(sict::Kingdom& Kingdom) forces the computer to cycle through my Kingdom array, based on user input.
//header file
#ifndef KINGDOM_H
#define KINGDOM_H
#include <cstdlib>
// TODO: sict namespace
namespace sict
{
// TODO: define the structure Kingdom in the sict namespace
struct Kingdom {
char m_name[32];
int m_population;
};
// TODO: declare the function display(...),
// also in the sict namespace
void display(const Kingdom& pKingdom);
void display(const Kingdom kingdoms[], size_t count);
}
#endif
`
//implementation .cpp
#include <iostream>
#include <cstdlib>
#include "Kingdom.h"
using namespace std;
// TODO: the sict namespace
namespace sict
{
// TODO:definition for display(...)
void display(const Kingdom& pKingdom) {
cout << pKingdom.m_name << ", " << "population " << pKingdom.m_population << endl;
}
void display(const Kingdom kingdoms[], size_t count) {
cout << "------------------------------" << endl;
cout << "Kingdoms of SICT" << endl;
cout << "------------------------------" << endl;
int pop = 0;
for (size_t i = 0; i < count; i++) {
cout << i + 1 << ". ";
display(kingdoms[i]);
pop += kingdoms[i].m_population;
}
cout << "------------------------------" << endl;
cout << "Total population of SICT: " << pop << endl;
cout << "------------------------------";
}
}
And my main,
#include <iostream>
#include <cstring> //for size_t definition
#include <vector>
#include "Kingdom.h"
using namespace std;
using namespace sict;
void read(Kingdom&);
int main() {
int count = 0; // the number of kingdoms in the array
// TODO: declare the pKingdom pointer here (don't forget to initialize it)
Kingdom *pKingdom = nullptr;
cout << "==========\n"
<< "Input data\n"
<< "==========\n"
<< "Enter the number of Kingdoms: ";
cin >> count;
cin.ignore();
if (count < 1) return 1;
// TODO: allocate dynamic memory here for the pKingdom pointer
pKingdom = new Kingdom[count];
for (int i = 0; i < count; ++i) {
cout << "Kingdom #" << i + 1 << ": " << endl;
// TODO: add code to accept user input for Kingdom i
read(pKingdom[i]);
}
cout << "==========" << endl << endl;
// testing that "display(...)" works
cout << "------------------------------" << endl
<< "The 1st Kingdom entered is" << endl
<< "------------------------------" << endl;
display(pKingdom[0]);
cout << "------------------------------" << endl << endl;
// expand the array of Kingdoms by 1 element
count = count + 1;
Kingdom *cpy_pKingdom = nullptr;
// TODO: allocate dynamic memory for count + 1 Kingdoms
cpy_pKingdom = new Kingdom[count];
// TODO: copy elements from original array into this newly allocated array
for (int i = 0; i < count; i++) {
cpy_pKingdom[i] = pKingdom[i];
}
// TODO: deallocate the dynamic memory for the original array
delete[] pKingdom;
// TODO: copy the address of the newly allocated array into pKingdom pointer
pKingdom = cpy_pKingdom;
// add the new Kingdom
cout << "==========\n"
<< "Input data\n"
<< "==========\n";
cout << "Kingdom #" << count << ": " << endl;
// TODO: accept input for the new element in the array
read(pKingdom[count - 1]);
cout << "==========\n" << endl;
// testing that the overload of "display(...)" works
display(pKingdom, count);
cout << endl;
// TODO: deallocate the dynamic memory here
//delete[] pKingdom;
//delete[] cpy_pKingdom;
getchar();
return 0;
}
// read accepts data for a Kingdom from standard input
//
void read(Kingdom& pkingdom) {
cout << "Enter the name of the Kingdom: ";
cin.get(pkingdom.m_name, 32, '\n');
cin.ignore(2000, '\n');
cout << "Enter the number of people living in " << pkingdom.m_name << ": ";
cin >> pkingdom.m_population;
cin.ignore(2000, '\n');
This can be quite the headache, and my hat goes off to all programmers out there that have all gone through this.

Answer 1

There are six overloads of istream::get. The arguments you are passing don't match any of them. That's why the compiler fails to compile that line.
The problem is that you are using char for the name member variable of Kingdom. That does not sound right. A name is usually a string. It char cannot be used to represent a name.
You can change name to be of type std::string or an array of char. If you use an array of char, you can use the function call like you have.
struct Kingdom {
char m_name[32]; // Since you are passing 32 to cin.get
int m_population;
};
You use std::string for name, you need to use std::getline.
struct Kingdom {
std::string m_name;
int m_population;
};
and ...
std::getline(std::cin, Kingdom.m_name);
I would recommend using std::string. They are much easier to work with.

Answer 2

istream::get has the following overloads (courtesy of http://en.cppreference.com/w/cpp/io/basic_istream/get):
(1) int_type get();
(2) basic_istream& get( char_type& ch );
(3) basic_istream& get( char_type* s, std::streamsize count );
(4) basic_istream& get( char_type* s, std::streamsize count, char_type delim );
(5) basic_istream& get( basic_streambuf& strbuf );
(6) basic_istream& get( basic_streambuf& strbuf, char_type delim );
You are calling get with three arguments, and out of the overloads above, only (4) matches.
As you can see, it expects a char pointer as its first argument, where as you are passing a char. (m_name)
I think you meant to define m_name as a char array (char m_name[128] for example), since that would be much more reasonable.