Windows Service Development Win32API C++ (g++ and Visual C++) - c++

Question

I created a sample service using Win32 API and C++.
I have once used Mingw g++ (7.1 - C++14) and Visual Studio 2010 independently.
The service I created using g++ does not start (after installation) and gives Error 1053: "The service did not respond in a timely fashion" when attempting to start, stop or pause a service.
I created an service using Visual C++ 2010 (same code with minor modification - for Unicode support) and it run properly on development machine (after installation).
However when I run the same service (after installation) I get error Error 1053: "The service did not respond in a timely fashion" when attempting to start, stop or pause a service .
Reference Article : Simple Windows Service in C++
Visual C++ :
WindowsService.cpp
#include "stdafx.h"
#include "Common.hpp"
using namespace std;
/*
*
*/
SERVICE_STATUS serviceStatus = {0};
SERVICE_STATUS_HANDLE serviceStatusHandle = NULL;
HANDLE serviceStopEvent = INVALID_HANDLE_VALUE;
VOID WINAPI ServiceMain (DWORD, LPSTR *);
VOID WINAPI ServiceCtrlHandler(DWORD);
DWORD WINAPI ServiceWorkerThread(LPVOID);
#define SERVICE_NAME _T("My Sample Service")
int _tmain(int argc, _TCHAR* argv[])
{
SERVICE_TABLE_ENTRY serviceTable[] =
{
{SERVICE_NAME, (LPSERVICE_MAIN_FUNCTION)ServiceMain},
{NULL, NULL}
};
if(StartServiceCtrlDispatcher(serviceTable) == FALSE)
{
DWORD errorMessageID = ::GetLastError();
FileOperations fo;
fo.printError(fo.getLastErrorAsString(errorMessageID));
return errorMessageID;
}
//cout << "Hello World";
FileOperations fo;
fo.printError("Testing Error");
fo.printLog("Ishaan Says Hello World");
return 0;
}
VOID WINAPI ServiceMain(DWORD argc, LPSTR *argv)
{
DWORD status = E_FAIL;
serviceStatusHandle = RegisterServiceCtrlHandler(SERVICE_NAME, ServiceCtrlHandler);
if(serviceStatusHandle == NULL)
{
FileOperations fo;
fo.printError(fo.getLastErrorAsString(::GetLastError()));
return;
}
//Tell The Service Controller we are starting
ZeroMemory(&serviceStatus, sizeof(serviceStatus));
serviceStatus.dwServiceType = SERVICE_WIN32_OWN_PROCESS;
serviceStatus.dwControlsAccepted = 0;
serviceStatus.dwCurrentState = SERVICE_START_PENDING;
serviceStatus.dwWin32ExitCode = 0;
serviceStatus.dwServiceSpecificExitCode = 0;
serviceStatus.dwCheckPoint = 0;
if(SetServiceStatus(serviceStatusHandle, &serviceStatus) == FALSE)
{
OutputDebugString(_T("My Sample Service : Service Main : SetSeviceStatus returned error. First (1) If"));
FileOperations fo;
fo.printError("My Sample Service : Service Main : SetSeviceStatus returned error");
}
//Preform task necessary to start a service here
//Create a stop event to wait on later
serviceStopEvent = CreateEvent(NULL, TRUE, FALSE, NULL);
if(serviceStopEvent == NULL)
{
serviceStatus.dwControlsAccepted = 0;
serviceStatus.dwCurrentState = SERVICE_STOP;
serviceStatus.dwWin32ExitCode = GetLastError();
serviceStatus.dwCheckPoint = 1;
if(SetServiceStatus(serviceStatusHandle, &serviceStatus) == FALSE)
{
OutputDebugString(_T("My Sample Service : ServiceMain : SetServiceStatus returned error. Second (2) If"));
FileOperations fo;
fo.printError("My Sample Service : ServiceMain : SetServiceStatus returned error. Second (2) If");
}
return;
}
//Tell Service Controller we are started
serviceStatus.dwControlsAccepted = SERVICE_ACCEPT_STOP;
serviceStatus.dwCurrentState = SERVICE_RUNNING;
serviceStatus.dwWin32ExitCode = 0;
serviceStatus.dwCheckPoint = 0;
if(SetServiceStatus(serviceStatusHandle, &serviceStatus) == FALSE)
{
OutputDebugString(_T("My Sample Service : ServiceMain : SetServiceStatus returned error. Tell Service Controller we are started"));
FileOperations fo;
fo.printError("My Sample Service : ServiceMain : SetServiceStatus returned error. Tell Service Controller we are started");
}
// Start a thread that will perform the main task of the service
HANDLE hThread = CreateThread(NULL, 0, ServiceWorkerThread, NULL, 0, NULL);
// Wait until our worker thread exits signaling that the service needs to stop
WaitForSingleObject(hThread, INFINITE);
//Perform Clean Up
CloseHandle(serviceStopEvent);
serviceStatus.dwControlsAccepted = 0;
serviceStatus.dwCurrentState = SERVICE_STOPPED;
serviceStatus.dwWin32ExitCode = 0;
serviceStatus.dwCheckPoint = 3;
if(SetServiceStatus(serviceStatusHandle, &serviceStatus) == FALSE)
{
OutputDebugString(_T("My Sample Service : Service Main : SetSeviceStatus returned error during exiting"));
FileOperations fo;
fo.printError("My Sample Service : Service Main : SetSeviceStatus returned error during exiting");
}
return;
}
VOID WINAPI ServiceCtrlHandler(DWORD ctrlCode)
{
switch(ctrlCode)
{
case SERVICE_CONTROL_STOP :
if(serviceStatus.dwCurrentState != SERVICE_RUNNING)
break;
serviceStatus.dwControlsAccepted = 0;
serviceStatus.dwCurrentState = SERVICE_STOP_PENDING;
serviceStatus.dwWin32ExitCode = 0;
serviceStatus.dwCheckPoint = 4;
if(SetServiceStatus(serviceStatusHandle, &serviceStatus) == FALSE)
{
OutputDebugString(_T("My Sample Service: ServiceCtrlHandler: SetServiceStatus returned error"));
FileOperations fo;
fo.printError("My Sample Service: ServiceCtrlHandler: SetServiceStatus returned error");
}
SetEvent(serviceStopEvent);
break;
default :
break;
}
}
DWORD WINAPI ServiceWorkerThread(LPVOID lpParam)
{
while(WaitForSingleObject(serviceStopEvent, 0) != WAIT_OBJECT_0)
{
FileOperations fo;
fo.printLog("Inside Service Thread");
Sleep(1000);
}
return ERROR_SUCCESS;
}
Common.hpp
#ifndef COMMON_COMMON_HPP_
#define COMMON_COMMON_HPP_
#include "stdafx.h"
using namespace std;
#define RETURN_SUCCESS true
#define RETURN_FAILURE false
class FileOperations
{
public :
void printError(string);
void printLog(string);
string getLastErrorAsString(DWORD);
private :
void getDateTime(void);
string DateTime;
};
stdafx.h
#pragma once
#include "targetver.h"
#include <stdio.h>
#include <tchar.h>
#include <ctime>
#include <cerrno>
#include <string>
#include <cstdio>
#include <fstream>
#include <string>
#include <cstdint>
#include <cstring>
#include <cstdlib>
#include <iostream>
#include <Windows.h>
Common.cpp
#include "stdafx.h"
#include "Common.hpp"
using namespace std;
bool GlobalVariables::startCapture = false;
void FileOperations::printLog(string str)
{
ofstream of;
of.open("C:\Log.dat", ios::out | ios::app);
this->getDateTime();
of << "[" << DateTime << "]" << "\t\t" << str << endl;
of.close();
}
void FileOperations::printError(string str)
{
ofstream of;
of.open("C:\Error.dat", ios::out | ios::app);
this->getDateTime();
of << "[" << DateTime << "]" << "\t\t" << str << endl;
of.close();
}
void FileOperations::getDateTime(void)
{
time_t now;
tm *dtStruct;
now = time(0);
dtStruct = localtime(&now);
DateTime.clear();
DateTime = to_string((long long)dtStruct->tm_mday) + ":" + to_string((long long)1 + dtStruct->tm_mon) + ":" + to_string((long long)1900 + dtStruct->tm_year) + "\t" +
to_string((long long)1 + dtStruct->tm_hour) + ":" + to_string((long long)1 + dtStruct->tm_min) + ":" + to_string((long long)1 + dtStruct->tm_sec);
}
//Returns the last Win32 error, in string format. Returns an empty string if there is no error.
string FileOperations::getLastErrorAsString(DWORD errorMessageID)
{
if(errorMessageID == 0)
return string("No error message has been recorded"); //No error message has been recorded
LPSTR messageBuffer = nullptr;
size_t size = FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS,
NULL, errorMessageID, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPWSTR)&messageBuffer, 0, NULL);
string message(messageBuffer, size);
//Free the buffer.
LocalFree(messageBuffer);
return message;
}
g++ :
main.cpp
#include "Common.hpp"
using namespace std;
/*
*
*/
SERVICE_STATUS serviceStatus = {0};
SERVICE_STATUS_HANDLE serviceStatusHandle = NULL;
HANDLE serviceStopEvent = INVALID_HANDLE_VALUE;
VOID WINAPI ServiceMain (DWORD, LPSTR *);
VOID WINAPI ServiceCtrlHandler(DWORD);
DWORD WINAPI ServiceWorkerThread(LPVOID);
#define SERVICE_NAME "My Sample Service"
int main(int argc, char** argv)
{
SERVICE_TABLE_ENTRY serviceTable[] =
{
{SERVICE_NAME, (LPSERVICE_MAIN_FUNCTION)ServiceMain},
{NULL, NULL}
};
if(StartServiceCtrlDispatcher(serviceTable) == FALSE)
{
DWORD errorMessageID = ::GetLastError();
FileOperations fo;
fo.printError(fo.getLastErrorAsString(errorMessageID));
return errorMessageID;
}
//cout << "Hello World";
FileOperations fo;
fo.printError("Testing Error");
fo.printLog("Ishaan Says Hello World");
return 0;
}
VOID WINAPI ServiceMain(DWORD argc, LPSTR *argv)
{
DWORD status = E_FAIL;
serviceStatusHandle = RegisterServiceCtrlHandler(SERVICE_NAME, ServiceCtrlHandler);
if(serviceStatusHandle == NULL)
{
FileOperations fo;
fo.printError(fo.getLastErrorAsString(::GetLastError()));
return;
}
//Tell The Service Controller we are starting
ZeroMemory(&serviceStatus, sizeof(serviceStatus));
serviceStatus.dwServiceType = SERVICE_WIN32_OWN_PROCESS;
serviceStatus.dwControlsAccepted = 0;
serviceStatus.dwCurrentState = SERVICE_START_PENDING;
serviceStatus.dwWin32ExitCode = 0;
serviceStatus.dwServiceSpecificExitCode = 0;
serviceStatus.dwCheckPoint = 0;
if(SetServiceStatus(serviceStatusHandle, &serviceStatus) == FALSE)
{
OutputDebugString("My Sample Service : Service Main : SetSeviceStatus returned error. First (1) If");
FileOperations fo;
fo.printError("My Sample Service : Service Main : SetSeviceStatus returned error");
}
//Preform task necessary to start a service here
//Create a stop event to wait on later
serviceStopEvent = CreateEvent(NULL, TRUE, FALSE, NULL);
if(serviceStopEvent == NULL)
{
serviceStatus.dwControlsAccepted = 0;
serviceStatus.dwCurrentState = SERVICE_STOP;
serviceStatus.dwWin32ExitCode = GetLastError();
serviceStatus.dwCheckPoint = 1;
if(SetServiceStatus(serviceStatusHandle, &serviceStatus) == FALSE)
{
OutputDebugString("My Sample Service : ServiceMain : SetServiceStatus returned error. Second (2) If");
FileOperations fo;
fo.printError("My Sample Service : ServiceMain : SetServiceStatus returned error. Second (2) If");
}
return;
}
//Tell Service Controller we are started
serviceStatus.dwControlsAccepted = SERVICE_ACCEPT_STOP;
serviceStatus.dwCurrentState = SERVICE_RUNNING;
serviceStatus.dwWin32ExitCode = 0;
serviceStatus.dwCheckPoint = 0;
if(SetServiceStatus(serviceStatusHandle, &serviceStatus) == FALSE)
{
OutputDebugString("My Sample Service : ServiceMain : SetServiceStatus returned error. Tell Service Controller we are started");
FileOperations fo;
fo.printError("My Sample Service : ServiceMain : SetServiceStatus returned error. Tell Service Controller we are started");
}
// Start a thread that will perform the main task of the service
HANDLE hThread = CreateThread(NULL, 0, ServiceWorkerThread, NULL, 0, NULL);
// Wait until our worker thread exits signaling that the service needs to stop
WaitForSingleObject(hThread, INFINITE);
//Perform Clean Up
CloseHandle(serviceStopEvent);
serviceStatus.dwControlsAccepted = 0;
serviceStatus.dwCurrentState = SERVICE_STOPPED;
serviceStatus.dwWin32ExitCode = 0;
serviceStatus.dwCheckPoint = 3;
if(SetServiceStatus(serviceStatusHandle, &serviceStatus) == FALSE)
{
OutputDebugString("My Sample Service : Service Main : SetSeviceStatus returned error during exiting");
FileOperations fo;
fo.printError("My Sample Service : Service Main : SetSeviceStatus returned error during exiting");
}
return;
}
VOID WINAPI ServiceCtrlHandler(DWORD ctrlCode)
{
switch(ctrlCode)
{
case SERVICE_CONTROL_STOP :
if(serviceStatus.dwCurrentState != SERVICE_RUNNING)
break;
serviceStatus.dwControlsAccepted = 0;
serviceStatus.dwCurrentState = SERVICE_STOP_PENDING;
serviceStatus.dwWin32ExitCode = 0;
serviceStatus.dwCheckPoint = 4;
if(SetServiceStatus(serviceStatusHandle, &serviceStatus) == FALSE)
{
OutputDebugString("My Sample Service: ServiceCtrlHandler: SetServiceStatus returned error");
FileOperations fo;
fo.printError("My Sample Service: ServiceCtrlHandler: SetServiceStatus returned error");
}
SetEvent(serviceStopEvent);
break;
default :
break;
}
}
DWORD WINAPI ServiceWorkerThread(LPVOID lpParam)
{
while(WaitForSingleObject(serviceStopEvent, 0) != WAIT_OBJECT_0)
{
FileOperations fo;
fo.printLog("Inside Service Thread");
Sleep(1000);
}
}
Common.cpp
#include "Common.hpp"
using namespace std;
bool GlobalVariables::startCapture = false;
void FileOperations::printLog(string str)
{
ofstream of;
of.open("Log.dat", ios::out | ios::app);
this->getDateTime();
of << "[" << DateTime << "]" << "\t\t" << str << endl;
of.close();
}
void FileOperations::printError(string str)
{
ofstream of;
of.open("Error.dat", ios::out | ios::app);
this->getDateTime();
of << "[" << DateTime << "]" << "\t\t" << str << endl;
of.close();
}
void FileOperations::getDateTime(void)
{
time_t now;
tm *dtStruct;
now = time(0);
dtStruct = localtime(&now);
DateTime.clear();
DateTime = to_string(dtStruct->tm_mday) + ":" + to_string(1 + dtStruct->tm_mon) + ":" + to_string(1900 + dtStruct->tm_year) + "\t" +
to_string(1 + dtStruct->tm_hour) + ":" + to_string(1 + dtStruct->tm_min) + ":" + to_string(1 + dtStruct->tm_sec);
}
//Returns the last Win32 error, in string format. Returns an empty string if there is no error.
string FileOperations::getLastErrorAsString(DWORD errorMessageID)
{
if(errorMessageID == 0)
return string("No error message has been recorded"); //No error message has been recorded
LPSTR messageBuffer = nullptr;
size_t size = FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS,
NULL, errorMessageID, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPSTR)&messageBuffer, 0, NULL);
string message(messageBuffer, size);
//Free the buffer.
LocalFree(messageBuffer);
return message;
}
Common.hpp
#ifndef COMMON_COMMON_HPP_
#define COMMON_COMMON_HPP_
using namespace std;
#include <ctime>
#include <cerrno>
#include <string>
#include <cstdio>
#include <thread>
#include <fstream>
#include <string>
#include <cstdint>
#include <cstring>
#include <cstdlib>
#include <unistd.h>
#include <cstdbool>
#include <iostream>
#include <windows.h>
//#include <pthread.h>
//#include "CommandList.hpp"
#define RETURN_SUCCESS true
#define RETURN_FAILURE false
class FileOperations
{
public :
void printError(string);
void printLog(string);
string getLastErrorAsString(DWORD);
private :
void getDateTime(void);
string DateTime;
};
class GlobalVariables
{
public :
static bool startCapture;
};
#endif /* COMMON_COMMON_HPP_ */
I used administrative account to install and run the service.