Cpp - EXC_BAD_ACCESS in recursion [closed] - c++

Question

Closed. This question needs debugging details. It is not currently accepting answers.
Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.
Closed 5 years ago.
Improve this question
Ive written a recursive function which uses std::vector for temporary data containers. The problem is that the code throws errors of EXC_BAD_ACCESS after certain recursive iterations, which dont seem to be associated with the code since the exception travels around.
I can produce an exception if i put anything at the place of the code printf("This is funny ... not"), any code before that seems to be executing okay.
I suspect that my system has run out of memory but from the activity monitor I can see that ive used 6.5 / 8GB RAM so this cannot be the case?
What may be the case of this EXC_BAD_ACCESS exception?
void Terrain::CarvePath(int index){
float endElevation = 0.0f;
int actualRowSize = 25 + 1;
int upperRow = index - actualRowSize;
int bottomRow = index + actualRowSize;
if(bottomRow + 1 > 25 * 25 || upperRow - 1 < 0){
return;
}
std::vector<int> surroundingIndices;
// Throws EXC_BAD_ACCESS. If removed throws EXC_BAD_ACCESS
// on the next line ( surroundingIndices.push_back() )
printf("This is funny ... not");
surroundingIndices.push_back(upperRow - 1);
surroundingIndices.push_back(upperRow);
surroundingIndices.push_back(upperRow + 1);
surroundingIndices.push_back(index - 1);
surroundingIndices.push_back(index + 1);
surroundingIndices.push_back(bottomRow - 1);
surroundingIndices.push_back(bottomRow);
surroundingIndices.push_back(bottomRow + 1);
if(lastVertex){
std::remove(std::begin(surroundingIndices),
std::end(surroundingIndices), lastVertex);
}
std::vector<float> surroundingIndicesY;
for (auto &&surroundingIndex : surroundingIndices) {
surroundingIndicesY.push_back
(vertices[surroundingIndex].position.y);
}
std::vector<float>::iterator it;
it = std::min_element(surroundingIndicesY.begin(),
surroundingIndicesY.end());
long vertexToDigIndexTemp =
std::distance(surroundingIndicesY.begin(), it);
int vertexToDigIndex = surroundingIndices[vertexToDigIndexTemp];
vertices[vertexToDigIndex].position.y -= 1.0f;
lastVertex = vertexToDigIndex;
if(vertices[index].position.y == endElevation) return;
CarvePath(vertexToDigIndex);
}

Answer 1

Seems to me like a typical stack overflow. Since your code is recursive, you might end up with a lot of return addresses on the stack, which can lead to your stack running out of space. Converting your code to a non-recursive version could solve the problem.