get error while trying to access a list [closed] - c++

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.
This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.
Closed 5 years ago.
Improve this question
I've got a list with a struct:
struct structPlacedBets
{
int betOption = 0;
int betValue = 0;
int betChips = 0;
int player = 1;
}
the list:
list <structPlacedBets> placedBets;
when writing to the list, there is no problem. I fill a temporary variable with the data, and then I handover the temporary variable to the list.
placedBets.push_back (tempPlacedBets);
Everything fine.
I also can access the list in the main function, everything good.
But, I wanted to handover the memory adress from the list to a function, and then output everything from the list. In the moment where I try to access the data, my program crashes.
Here is the code:
struct structPlacedBets
{
int betOption = 0;
int betValue = 0;
int betChips = 0;
int player = 1;
}
list <structPlacedBets> placedBets;
structPlacedBets tempPlacedBets; //temporary variable for filling the list
.
.
.
placedBets.push_back (tempPlacedBets);
.
.
.
void outputList(list <structPlacedBets> &tempList)
{
list <structPlacedBets>::iterator Iterator;
for (Iterator == tempList.begin(); Iterator != tempList.end(); Iterator++)
{
cout << Iterator->betOption; //here the program crashes
}
}
int main()
outputList(placedBets);
return 0;
When accessing the list directly in the main, without another function, everything is fine.
Works well:
int main()
list <structPlacedBets>::iterator Iterator;
for (Iterator = placedBets.begin(); Iterator != placedBets.end(); Iterator++)
{
cout << (*Iterator).betOption << endl;
cout << (*Iterator).betValue << endl;
cout << (*Iterator).betChips << endl;
cout << (*Iterator).player << endl;
}
Hope, anybody knows the problem and the answer.
Thank you.

Answer 1

In the first example, you have a typo:
for (Iterator == tempList.begin(); Iterator != tempList.end(); Iterator++)
// ^^
Iterator was never initialised to anything! Comparing it, then dereferencing it (and, if you got that far, incrementing and comparing it again) all has undefined behaviour.
In the second example you correctly wrote =.
Pay closer attention to your code, and turn on your compiler's warnings.