Multiple variable declarations [closed] - vmware

Question

Closed. This question needs to be more focused. It is not currently accepting answers.
Want to improve this question? Update the question so it focuses on one problem only by editing this post.
Closed 6 years ago.
Improve this question
I have a script which I use it for multiple tasks like
Create Folder in vSphere
Create ResourcePools
Create a VM (VMware)
Configure IP/DNS
Add it to domain, …
For this I need multiple inputs needed like VM name, vCenter Server name, userid, password, etc. How do I declare the input variables externally (separate from Main script) and also make it generic in look.
I tried using below procedure but it gives me call depth overflow error.
VARIABLE_DECLARATION.ps1:
VariableDeclaration = #{
[CmdletBinding()]
Param (
[Parameter(Mandatory=$True)]
[Parameter(ValueFromPipeline=$true)]
[int]$CustomerCID = '10000';
[string]$CustomerName = "ABCcorp";
[string]$vCenterName = "vCenter.ABCcorp.com";
[string]$vCenterUserName = "administrator#vsphere.local";
[string]$vCenterPassword = "ABCcorp123!";
[string]$CustomerPODLocation = "VW1";
[string]$DatacenterName = "ABCcorpDC";
[string]$ClusterName = "ABCcorpcluster";
[string]$InfraResourcePoolName = ($CustomerCID + "-" + $CustomerName + "-" + "Infrastructure");
[string]$DesktopResourcePoolName = ($CustomerCID + "-" + $CustomerName + "-" + "Desktop");
[string]$CustomerFolderName = ($CustomerCID + "-" + $CustomerName);
[string]$ConnectionType = "xConnect";
[int]$VLANID = '237';
[string]$CustomerDVPortGroupName = ($CustomerPODLocation + "-" + $ConnectionType + "-" + $CustomerCID + "-" + $CustomerName + "-" + $VLANID);
[int]$NumberofPorts = '1024';
[string]$AD1computername = ($CustomerCID + "-RADSVR01-v" + $CustomerName + ".vdi");
[string]$AD2computername = ($CustomerCID + "-RADSVR02-v" + $CustomerName + ".vdi");
[string]$sourcetemplate = "BaseWin2012R2";
[string]$description = "ABCcorp Infra Systems";
[string]$OSCustomizationspec = "ABCcorp";
[string]$AD1IP = "10.0.0.10";
[string]$AD2IP = "10.0.0.11";
[string]$SNM = "255.255.255.0";
[string]$DG = "10.0.0.1";
[string]$DNS = "10.0.0.2";
[string]$HostUsername = "root";
[string]$HostPassword = (ConvertTo-SecureString -String "ABCcorp123" -AsPlainText -Force);
[string]$HostCredential = (New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList $HostUsername, $HostPassword)
)
}

Answer 1

PowerShell parameter definition doesn't work that way. Create a function for each of your tasks with the parameters required for that specific function/task. To make the functions available put them in a script and dot-source it, or put them in a module and load that module.
Example for dot-sourcing a PowerShell script:
vm-functions.ps1:
function New-VSphereFolder {
Param(
[Parameter(Mandatory=$true, ValueFromPipeline=$true)]
[string]$FolderName,
[Parameter(Mandatory=$false, ValueFromPipeline=$true)]
[string]$vCenterName = "vCenter.ABCcorp.com",
[Parameter(Mandatory=$false, ValueFromPipeline=$true)]
[string]$Username = "administrator#vsphere.local",
[Parameter(Mandatory=$false, ValueFromPipeline=$true)]
[string]$Password = "ABCcorp123!",
...
)
...
}
function New-ResourcePool {
...
}
Dot-source the script the script to make the functions available in the current context, then use whichever function you need:
PS C:\> . C:\path\to\vm-functions.ps1
PS C:\> New-VSphereFolder -FolderName ...
...
For further information about parameters in PowerShell scripts/functions see here and here.