WM_SETICON not working when program launched via shortcut - c++

I am using WM_SETICON to change the icon of an application. This works when the program is run in VisualStudio debugger, or via commandline, but uses the wrong taskbar icon when launched through a desktop shortcut on Windows 7. Right clicking to pin the program to the taskbar and then unpinning it causes the icon to display correctly.
HICON icon = (HICON) LoadImage(NULL, iconStr, IMAGE_ICON, 32, 32, LR_LOADFROMFILE| LR_SHARED);
SendMessage(hwnd, WM_SETICON, ICON_BIG, (LPARAM)icon);
SendMessage(hwnd, WM_SETICON, ICON_SMALL, (LPARAM)icon);
SendMessage(hwnd, WM_SETICON, ICON_SMALL2, (LPARAM)icon);
It seems as though something about launching through a shortcut is causing the program to use a stale cached icon and ignore WM_SETICON. Also the small icon next to the program titlebar is updating properly, it is only the icon on the taskbar that has issues.
I really do need to set the icon programatically because it will change based on commandline. Does anyone know of a way to make this work? Thanks.

I did find a workaround. Since the exe referenced by the shortcuts can't change it's icon, it can launch an exe with a different filename that will then be able to change taskbar icons with WM_SETICON.
shortcuts (1-n) each have their own icon and point to IgnoresWMSetIcon.exe.
On startup IgnoresWMSetIcon.exe launches CanChangeIcon.exe then closes. CanChangeIcon.exe is then able to function normally.
Still interested in an explanation of why this is the case, if someone knows.

Related

How to set the icon of an application EXE file programmatically?

How to change the default application icon to a custom icon Programmatically, i.e. without using a resource file (just putting an icon beside the EXE file).
I only know a way that uses a resource file, but I want to know a way that does that programmatically (code and external icon).
Also, I have tried the following code:
HANDLE hIcon = LoadImage(0, L"icon.ico", IMAGE_ICON, 0, 0, LR_DEFAULTSIZE | LR_LOADFROMFILE);
HWND hwnd = GetConsoleWindow();
if (hIcon) {
//Change both icons to the same icon handle.
SendMessage(hwnd, WM_SETICON, ICON_SMALL,(LPARAM) hIcon);
SendMessage(hwnd, WM_SETICON, ICON_BIG, (LPARAM) hIcon);
//This will ensure that the application icon gets changed too.
SendMessage(GetWindow(hwnd, GW_OWNER), WM_SETICON, ICON_SMALL, (LPARAM) hIcon);
SendMessage(GetWindow(hwnd, GW_OWNER), WM_SETICON, ICON_BIG, (LPARAM)hIcon);
}
But that code just changes the icon that at the left corner of the window, not the application EXE file.
How to set the icon of an application EXE file programmatically?
An EXE cannot change its own icon programmably at runtime (it can only change the icon displayed in its UI windows, as you discovered). The EXE's icon must be stored statically in the EXE's resources, that is where the OS looks for the icon. And the EXE's resources cannot be altered while the EXE is running.
However, you CAN create a shortcut to the EXE and then change the icon of the shortcut.

Setting icon for application VS Express 2012 c++

I have been trying to get an icon added to my application as a resource, so that it is displayed with my application in VS 2012 Express using c++. So far I have picked up the following code to add to my rc file from other questions and forums.
IDI_APP ICON "resources/Icon.ico"
The icon is displayed on the desktop with the exe, and on the taskbar when the program is running. However in certain situations such as on the task manager the icon for the application dies not show up and instead the default program icon is displayed. I was wondering if anyone knows how to alter my code so that the icon is always associated with my program. I have heard that the problem may result from needing different sized icons however I have many sizes of icons within my ico file created with the program IcoFX. I was also wondering if I needed to programmatically set the icon for it to work in any place the application is associated with. I have tried rebuilding and renaming my program to update the icon in the shell. I am using a sfml window instead of the winapi and a HWND window.
Double check that you created a single .ico file with multiple resolutions, usually 16x16, 32x32, 48x48, 96x96.
Load your icon with something like
ICON hIcon = LoadIcon(GetModuleHandle(NULL), MAKEINTRESOURCE(IDI_ICON1));
Notify with Windows messages of the icon
//Change both icons to the same icon handle.
SendMessage(hwnd, WM_SETICON, ICON_SMALL, hIcon);
SendMessage(hwnd, WM_SETICON, ICON_BIG, hIcon);
//This will ensure that the application icon gets changed too.
SendMessage(GetWindow(hwnd, GW_OWNER), WM_SETICON, ICON_SMALL, hIcon);
SendMessage(GetWindow(hwnd, GW_OWNER), WM_SETICON, ICON_BIG, hIcon);
Finally reset the shell icon cache as described here or by just restarting/logging out.
Additional resources and references:
https://stackoverflow.com/a/19656000/1938163
https://stackoverflow.com/a/2723270/1938163

How to change the icon in taskbar using windows api

I am writing a small windows application.
I want to create a installer using nsis script.
I know how to change the default application icon, start menu icon and desktop shortcut icon by using
Application icon : !define MUI_ICON "${INSTALL_ICON}"
Shortcut on start menu : CreateShortCut "$SMPROGRAMS\$StartMenuFolder\shorcutName.lnk" "$INSTDIR\executableName.exe" "" "$INSTDIR\${INSTALL_ICON}" 0
Shortcut on Desktop : CreateShortCut "$DESKTOP\shorcutName.lnk" "$INSTDIR\executableName.exe" "" "$INSTDIR\${INSTALL_ICON}" 0
But I want to also change the icon shown on the top left of the application window.
And icon shown in task manager and icon shown on task bar. I think should be done using winapi.
Any help would be appreciated.
Thanks in advance
It's important to change all icons, including the application, both small and big:
//Change both icons to the same icon handle.
SendMessage(hwnd, WM_SETICON, ICON_SMALL, hIcon);
SendMessage(hwnd, WM_SETICON, ICON_BIG, hIcon);
//This will ensure that the application icon gets changed too.
SendMessage(GetWindow(hwnd, GW_OWNER), WM_SETICON, ICON_SMALL, hIcon);
SendMessage(GetWindow(hwnd, GW_OWNER), WM_SETICON, ICON_BIG, hIcon);

change icon of a dialog

i am recently editing an open source project in visual c++ 2010 , i don't know much about vc++ ,(i have only 5 days of experience in c++), with my little knowledge i am changing some user interface of the project
there is only one icon in my project ,the apps shows the main icon as icon , at the same time i want to make that icon to be on the title of a dialog also (the dialog will be shown when a button in main form is clicked),
the dialog is already in the resources/dialogs but i want to change the icon of it ;
You need to find the dialog procedure of the dialog you're interested in, and in the WM_INITDIALOG message handler (you need to add it if it's not already present) use WM_SETICON to set the icon:
// hIcon is your icon handle
SendMessage(hDlg, WM_SETICON, ICON_SMALL, (LPARAM)hIcon);
SendMessage(hDlg, WM_SETICON, ICON_BIG, (LPARAM)hIcon);

Problems with setting application icon

(I'm using Visual Studio 2008, though I remember having similar problems with older versions as well.)
I've tried several different methods (many of them mentioned in this other question), but I am still having some strange issues:
When including an icon as a resource, it does show up as the executable file's icon immediately, but for the icon to show up on the taskbar, I have to restart the computer. Until then, it continues to show up as whatever the previous icon was. Cleaning the solution, restarting VS, doesn't have any effect. Not a really big issue, as it won't affect a released exe, but it would be nice to know where it's keeping the old icon cached and how to get rid of it.
No matter what I do, the icon displayed when alt-tabbing is the default app icon (square and white and generic). This includes embedding the icon in the executable, as well as setting ICON_BIG with WM_SETICON.
As for the second matter, my code looks something like:
hIcon = (HICON)(
LoadImage( NULL, szFilename, IMAGE_ICON, 32, 32, LR_LOADFROMFILE ) );
if( hIcon )
SendMessage( hWnd, WM_SETICON, ICON_BIG, (LPARAM)hIcon );
However, after sending WM_SETICON, GetLastError() returns 6, "The handle is invalid.". hWnd is a valid window handle, and hIcon appears to be a valid icon handle. I've tried searching for reasons why WM_SETICON could cause that error, and at the very least, to figure out WHICH handle it thinks is invalid, but no luck yet. I've cleared the error code immediately before calling SendMessage(), so it has to be set somewhere in the processing of the message.
I tried an alternate method, loading the icon from the exe itself, where the ID of the resource is 101 (it's the first and only resource included):
hIcon = (HICON)(
LoadImage( GetModuleHandle( NULL ), MAKEINTRESOURCE( 101 ),
IMAGE_ICON, 48, 48, 0 ) );
if( hIcon )
SendMessage( hWnd, WM_SETICON, ICON_BIG, (LPARAM)hIcon );
... but the same thing happens; after calling SendMessage(), GetLastError() gives the same error status.
I've tried different dimensions (such as 48x48, all of which are present in the icon file), but to no different effect. I know it's definitely finding and loading the images, because if I specify a size that doesn't exist or an invalid resource ID or the wrong filename (depending on how I am loading it), it fails out long before SendMessage().
Strangely, if I specify ICON_SMALL instead of ICON_BIG, the call succeeds with no error status, but from the docs, I need to use ICON_BIG to set the icon used while alt-tabbing. Also, if I use ICON_BIG but load the 16x16 icon, I get no error status, but nothing changes.
Any ideas about what could be causing WM_SETICON to fail? Anything terribly wrong with any of the code I've posted (aside from formatting/style/casting issues, as it's simplified to just the basics)?
I've revisited this to see if I can close out my question. I have been unable to get the app's icon to show up in the alt-tab list just through embedding it in the executable; it will show up in the taskbar, as the file's icon in Explorer, and elsewhere just fine.
I figured I'd try something simpler for setting the icon manually, and went with LoadIcon() instead, as the code below shows:
HICON hIcon = LoadIcon( GetModuleHandle(NULL), MAKEINTRESOURCE(IDI_ICON1) );
if( hIcon )
{
SendMessage( GetHandle(), WM_SETICON, ICON_BIG, (LPARAM)hIcon );
DestroyIcon( hIcon );
}
// ... Same for ICON_SMALL
This seems to have done the trick. I really don't know why, but so far it's the only change that had any effect. It's really not an issue I should spend any more time on, so I'll just go with this.
OK, this worked a treat for me :
HICON hIconSmall =(HICON)LoadImage(handleToYourApplicationInstance, MAKEINTRESOURCE(IDI_ICON1), IMAGE_ICON,16, 16, 0);
HICON hIconLarge =(HICON)LoadImage(handleToYourApplicationInstance, MAKEINTRESOURCE(IDI_ICON1), IMAGE_ICON,256, 256, 0); // Big for task bar, small loaded otherwise.
SendMessage(yourWindowHandle, WM_SETICON, ICON_SMALL, (LPARAM)hIconSmall) ;
SendMessage(yourWindowHandle, WM_SETICON, ICON_BIG, (LPARAM)hIconLarge) ;
I've used a single .ico file with multiple resolutions 16x16, 32x32, 48x48, 96x96 without problems, as application icon. Then windows will pick up the right size.
The windows shell have an icon cache, there is a trick to restart it without rebooting or logout from the current session, or killing explorer.exe from task manager.
For anyone coming to this same difficulty if you are going to change ICON_BIG you must first send WM_SETICON with ICON_SMALL and then proceed to ICON_BIG.
For example:
SetLastError(0);
SendMessage(windowHandle, WM_SETICON, ICON_SMALL, (LPARAM)iconsmallHandle);
[do error handling]
SetLastError(0);
SendMessage(windowHandle, WM_SETICON, ICON_BIG, (LPARAM)iconbigHandle);
[do error handling]
You will need to use SetLastError after the first SendMessage to clear any returned error.
If you are just setting ICON_SMALL you can ignore ICON_BIG. For whatever reason in all of my tests you must set ICON_SMALL regardless if that icon needs to change or not, before attempting to change ICON_BIG, otherwise you will always get error code 0x6 (invalid handle).
If found the solution for me. I created an invisible CFrameWnd application window and then a few other main windows (which are dialog windows). The magic undocumented rule is: You have to change the big icon in the first created CFrameWnd. While each window keeps it's own ICON_BIG instance, it does not use them. So it seems not possible to show different taskbar icons for different windows inside one application.