C++ executable crashing [closed] - c++

Question

Closed. This question needs debugging details. It is not currently accepting answers.
Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.
Closed 7 years ago.
Improve this question
I am starting to create a binary tree. So far all I have added is an insert function and I believe it works fine. When I compile my application, header and implementation files together it produces a executable but with an error code above it about exception handler used.... When I go to run the executable it crashes. I don't understand why it is crashing, can someone please help! Thanks in advance.
The command line errors http://gyazo.com/7ca1e8fb1a66da39e927e9ba627d3f53
My application file called mainprogramming.cpp
#include <iostream>
#include <cstdlib>
#include "Header.h"
using namespace std;
int main()
{
int Rndnums[10] = {3, 99, 76, 49, 32, 9, 77, 64, 81, 24};
BinaryTree *tree = new BinaryTree();
for(int i = 0; i < 10; i++)
{
tree->insert(Rndnums[i]);
}
return 0;
}
My header file called Header.h
class BinaryTree
{
// Can only be accessed by the class itself
private:
struct node
{
// Data stored in this node of he tree
int data;
// The left branch of the tree
node *left;
// The right branch of the tree
node *right;
};
node *tree;
void insert(node *tree, int value);
// Can be accessed by all
public:
BinaryTree(){};
~BinaryTree();
void insert(int value);
};
My implementation file called implementation.cpp
#include <iostream>
#include <cstdlib>
#include "Header.h"
using namespace std;
// Inserts a value into the tree - notice **
void BinaryTree::insert(node *tree, int value)
{
// Check if nullptr. If so set new node
if (tree == nullptr)
{
// Create new node
tree = new node;
// Set new value
tree->data = value;
// Set branches to nullptr
tree->left = nullptr;
tree->right = nullptr;
}
// If the input value is less than the node in the tree
else if(value < tree->data)
{
insert(tree->left, value);
cout << "The value " << value << "has been added as a left child\n";
}
// If the input value is greater than the node in the tree
else if(value > tree->data)
{
insert(tree->right, value);
cout << "The value " << value << "has been added as a right child\n";
}
else
{
cout << "The value " << value << "can only be equal and must already exist in the tree\n";
}
}
void BinaryTree::insert(int value)
{
insert(this->tree, value);
cout << "It ran";
}

Answer 1

Your problem is in your insert call:
void BinaryTree::insert(node * leaf_head, int value)
{
...
}
You are copying the pointer address then trying to create an object in that memory space, and then modifying that object. It works fine when you change it to a reference to that pointer:
void BinaryTree::insert(node * & leaf_head, int value)
{
...
}
That way you are actually modifying the tree pointer within BinaryTree instead of a copy of it.