Collatz Conjecture C++ [closed] - c++

Question

Closed. This question needs details or clarity. It is not currently accepting answers.
Want to improve this question? Add details and clarify the problem by editing this post.
Closed 8 years ago.
Improve this question
I created this function (see below), that works perfectly; however, I was tasked in changing the function to take a parameter that does the same thing just for the function I passed into it.
int collatz(){
int temp, num;
//num = 0;
cout << "pick a number to turn into one:";
cin >> num;
temp = 0;
while(num != 1){
if(num%2 == 0){
num = num/2;
temp++;
}
else if(num&2 != 0){
num = (3*num) + 1;
temp++;
}
}
cout << num << "number of times run: " << temp;
return 0;}
I came up with this; however, it gives me an error:
error C3861: 'collatztwo': identifier not found warning C4554: '&' :
check operator precedence for possible error;
use parentheses to clarify precedence
int collatztwo(int a){
int temp, num;
//num = a;
temp = 0;
while(a != 1){
if(a%2 == 0){
a = a/2;
temp++;
}
else if(a&2 != 0){
a = (3*a) + 1;
temp++;
}
}
cout << "looped: " << temp;
return 0;}

Answer 1

From the errors OP listed in his comment:
error C3861: 'collatztwo': identifier not found
When you made your new function, did you include a prototype for it before the call site? You have to declare int collatztwo(int a); at the top of your source file, or move the function definition before where you use it.
warning C4554: '&' : check operator precedence for possible error; use parentheses to clarify precedence
As already mentioned in the comments, you need to include a pair of parentheses around a&2 or it will do the wrong thing. else if ((a&2) != 0){