render from another method - django

Question

I have two urls defined in my urls.py one to go to homepage.html and one to go to unauthorized.html. I created the following in my views.py. My goal was to have a common method called "check_authorized" and to call that from my homepage method and if it met a condition here if 'isFoo' is false to call 'unauthorized' method so that it can redirect to the unauthorized.html. However when I call homepage.html it doesn't redirect to that page instead it stays on homepage.html ( I even removed the if block so that the code path hist the 'unauthorized' method directly). Here is the view.py
def check_authorized(request):
ctx = RequestContext(request)
posixGroups = []
#Have some logic to add groups
ctx['isFoo'] = 'foo' in posixGroups
if not ctx['isFoo']:
unauthorized(request)
return ctx
def unauthorized(request):
ctx = RequestContext(request)
return render_to_response('unauthorized.html', ctx)
def homepage(request):
ctx = check_authorized(request)
return render_to_response('homepage.html', ctx)
In my Urls.py I have in the url patterns
(r'^unauthorized', views.unauthorized),
(r'', views.homepage),
Update:
Adding decorator class
def check_authorized(request, login_url=None):
def is_authorized(u):
user = request.META['REMOTE_USER']
posixGroups = []
#Code to get posix groups
isFoo = 'foo' in posixGroups
if not isFoo:
return False
return True
return user_passes_test(is_authorized, login_url=login_url)
def unauthorized(request):
ctx = RequestContext(request)
return render_to_response('unauthorized.html', ctx)
#check_authorized(login_url='unauthorized')
def homepage(request):
ctx = check_authorized(request)
return render_to_response('homepage.html', ctx)
Error
Exception Type: TypeError
Exception Value:
check_authorized() takes at least 1 argument (1 given)

Answer 1

This is a very good use case for a decorator, like login_required:
from django.contrib.auth.decorators import login_required
#login_required(login_url='/accounts/login/')
def my_view(request):
...
It would redirect the user to the login_url if it is not authenticated.
So, since you have a custom logic that decides whether to redirect the user to login_url or not, you need a custom decorator that would be similar to Django built-in decorators:
from django.contrib.auth.decorators import user_passes_test
def check_authorized(request, login_url=None):
def is_authorized(user):
# Have some logic that returns True/False
...
return user_passes_test(is_authorized, login_url=login_url)
#check_authorized(login_url='unauthorized/')
def homepage(request):
return render_to_response('homepage.html')
Also see:
group_required decorator