Array's in function confusion C++ [closed] - c++

Question

Closed. This question does not meet Stack Overflow guidelines. It is not currently accepting answers.
Questions asking for code must demonstrate a minimal understanding of the problem being solved. Include attempted solutions, why they didn't work, and the expected results. See also: Stack Overflow question checklist
Closed 9 years ago.
Improve this question
I need to write a program that is passed an array of int and its size, and with that it prints out the numbers that are above average. Can anyone help clear this question up for me? I am sitting here wondering what the heck it is asking, and I am still quite new to programming so i don't know what to do. Sorry I sound so unable, but I am just confused. Thank you to anybody who can help. This is all I have so far:
Here is the updated code, but I still can't figure out why there aren't multiple average values displaying out, or how to get the output value to be correct.
EDIT: Changed a couple int values in the average() function to floats, but there is still a problem with the total value's at the end
#include <iostream>
using namespace std;
int average(int values[],int size);
int main(){
int size;
int values[] = {1,2,3,4,5,6};
cout << "Please input the size of the array" << endl;
cin >> size;
int output = average(values, size);
if(values[size]>output){
cout << "The values above average are: " << output << endl;
}
return 0;
}
int average(int values[],int size){
float temp=0.0;
for(int i=0;i<size;i++){
temp += values[i];
}
float end=temp/size;
return end;
}

Answer 1

your supposed to create an array of intigers and pass it to the average function, and need to pass the size(so that you know how many times to loop). In the loop in your Average function add all the values to a temporary value, then divide by the count input-ed to the function.
//returns the average
int average(int Values[],int Size){
//perhaps declare a temporary value here
for(int i=0;i<Size;i++){
//add all the values up and store in a temporary value
}
//here divide by Size and return that as the average
}
this
if(values[size]>output){
cout << "The values above average are: " << output << endl;
}
should be replaced with something like:
for(int i=0;i<size;i++){
if(values[i]>output){
cout << "The values above average are: " << values[i] << endl;
}
}

Answer 2

Here is a less convoluted solution than those posted. Main feature: It actually does do what it should:
#include <iostream>
template<size_t N>
float average( const int (&value)[N] ) {
float total( 0.0f );
// Sum all values
for ( size_t index = 0; index < N; ++index )
total += value[index];
// And divide by the number of items
return ( total / N );
}
int main() {
int value[] = { 1, 2, 3, 4, 5, 6 };
// Calculate average value
float avg = average( value );
const size_t count = ( sizeof( value ) / sizeof( value[0] ) );
// Iterate over all values...
for ( size_t index = 0; index < count; ++index )
// ... and print those above average
if ( value[index] > avg )
std::cout << value[index] << std::endl;
return 0;
}
Live example at Ideone. Output:
4
5
6