ReadProcessMemory trouble not updating - c++

Question

This program does work at start, but than goes wrong after few loops
I am having trouble with ReadProcessMemory. It works at beginning of my program and reads in large string, but than it stops updating the values correctly. For example it will keep the previous string and stay with that string for rest of program or it will have completely nothing in the string until I shut program off. This happens at random times after first two times it works. The basic address contains a string of text of an item through hover effect in game. However readprocessmemory seems to stop working after few times and I have double checked that the address is still updating the correct values through cheat engine and it is but it is not updating correctly in program. I know code is badly written and I should use vectors etc...
The Problem occurs here:
while(temp.size() < 150 ){
do{
// memset(&buffer[0], 0, sizeof(buffer));
ReadProcessMemory(hProcHandle, (LPCVOID)myaddr, &buffer, sizeof(buffer), NULL);
temp = std::string((char*)buffer);
}
while(temp == previous);
std:: cout << temp.size() << std::endl;
}
The above code was not a loop before, I tried recalling it again until it has new value or not null,however once the program stops working with bad values it just remains stuck in loop no matter how many times I call it, but the same address in cheat engine is being updated at same time, I have double checked that. The main problem in this loop is that readprocessmemory continues to have the same value as previous call and stays that way until shut down the program. The address is being updated in game at same time this is running.
#include <iostream>
#include <Windows.h>
#include <string>
#include <ctime>
#include <sstream>
#include <algorithm>
#include <vector>
DWORD ariaBase = 0x400000 + 0x009B5A20;
std::string teatime[] = {" + 5 E"," + 6 Acc"," + 5 Acc"," + 6 Acc"," + 5 Acc"," + 7 Crit"," + 6 Damage"," + 5 Damage"," + 4 Damage"," + 3 Crit"};
unsigned char* buffer[800] = {0};
std::string temp = "";
std::string previous = "";
int myaddr = 0;
bool match[5];
DWORD aOffset[] = {0x724, 0x37C, 0x0, 0xAC, 0x50};
int count = 0;
std::vector<std::string> stats;
bool statsFound = false;
void WriteToMemory(HANDLE hProcHandle){
stats.clear();
temp = "";
while(temp.size() < 150 ){
do{
// memset(&buffer[0], 0, sizeof(buffer));
ReadProcessMemory(hProcHandle, (LPCVOID)myaddr, &buffer, sizeof(buffer), NULL);
temp = std::string((char*)buffer);
}
while(temp == previous);
std:: cout << temp.size() << std::endl;
}
previous = temp;
std::replace( temp.begin(), temp.end(),(char)'\\', '*');
stats = findStats(temp);
//for( std::vector<std::string>::const_iterator i = stats.begin(); i != stats.end(); ++i)std::cout << *i << ' ' << std::endl;
}
int main(){
...code...
...code...
...code...
...code...
while(statsFound == false){
round++;
checkItem();
Sleep(2000);
WriteToMemory(hProcHandle);
std::cout << round << std::endl;
for( std::vector<std::string>::const_iterator i = stats.begin(); i != stats.end(); ++i)std::cout << *i << ' ' << std::endl;
for(int i = 0; i < stats.size();i++){
for(int j = 0; j < 10;j++){
if(("Identified Attribute:" + teatime[j]) == stats[i])match[i] = true;
}
}
count = 0;
for(int i = 0; i < stats.size();i++){
if(match[i] != true)statsFound = false;
else count++;
if(count == stats.size())statsFound = true;
}
match[0] = false;
match[1] = false;
match[2] = false;
match[3] = false;
if(statsFound == false)MouseStart();
}
...code...
...code...
...code...
}

Answer 1

Can you say what resides in the memory of the target process from which you're reading the data?
Have you heard about GetLastError function? Call it immediately after ReadProcessMemory returns and that may give a clue.