vector with characters displaying - c++

Question

I have a problem with displaying the data entered in register. The folowing program that I wrote displays just the last register.( ziua=day , inregistrari=registers, data=date (ex. 03.02.2013))
#include <iostream>
#include <conio.h>
#include <stdlib.h>
#include <stdio.h>
using namespace std;
int main()
{
char ziua[30],data[30],inregistrari[90];
int n,i;
cout<<"INPUT DATA"<<endl;
system("Pause");
cout<<"\nEnter the day in which you want to perform the register: ";
cin>>ziua;
cout<<"\nDATE:";
cin>>data;
cout<<"\nEnter the number of registers you wanna perfom for the day "<<ziua<<":";
cin>>n;
for(i=1;i<=n;i++)
{
cout<<"\nRegister "<<i<<":";
gets(inregistrari);
}
cout<<"The data for the day of "<<ziua<<" are the following: ";
cout<<"\nDATE: "<<data;
for(i=1;i<=n;i++)
cout<<"\n"<<inregistrari;
getch();
}

Answer 1

you are programming in C++, you should use std::string instead of C-style strings.
inregistrari[90] is an array of characters big enough to hold 1 string of max length of 89 chars (+ terminating character), but your loop seems to be treating it as an array or strings (although in this case gets(inregistrari); keeps on rewriting the same string)
function gets is generally deprecated, in C you should use fgets instead (yet this is C++, thus the real solution here should be using std::getline)
instead of C-style arrays, use std::vector<std::string> here.
printing the inregistrari is in the body of for loop, but each iteration of this loop does exactly the same thing (the printing does not depend on i in any way)
using namespace std; within the global space is a bad practice
you don't have to declare all variables at the beginning of the function, this was necessary in old ANSI C (about 20 years ago)
Here's an example how it could look like instead:
#include <iostream>
#include <string>
#include <vector>
int main()
{
std::string day, date;
int registerCount;
std::cout << "INPUT DATA"
<< std::endl << std::endl
<< "Enter the day in which you want to perform the register: "
<< std::endl;
std::cin >> day;
std::cout << "DATE:" << std::endl;
std::cin >> date;
std::cout << "Enter the number of registers you wanna perfom for the day "
<< day << ":" << std::endl;
std::cin >> registerCount;
std::vector<std::string> registers(registerCount);
for (int i = 0; i < registerCount; ++i)
{
std::cout << "Register " << i << ":" << std::endl;
std::getline(std::cin, registers[i]);
}
std::cout << "The data for the day of " << day << " are the following: "
<< std::endl;
std::cout << "DATE: " << date << std::endl;
for (int i = 0; i < registerCount; ++i)
std::cout << registers[i] << std::endl;
}
Note that you might wrap std::getline(std::cin, registers[i]) with if statement and check whether a valid stream object has been return and in case of empty lines, it will read the empty string thus you might also make sure that !registers[i].empty().