C++ for loop crashes halfway through - c++

Question

I've just started learning about C++ and I'm currently stuck with this for loop that crashes everytime I execute it (it's part of a larger code)
void placeItem()
{
int settler = 20, castle = 5, tower = 10, mine = 10, E = 100;
int player1Settler = 0, player1Castle = 0, player1Tower = 0, player1Mine = 0;
int player2Settler = 0, player2Castle = 0, player2Tower = 0, player2Mine = 0;
int dice, x, y;
currentBoardStatus();
cout << "Player " << playerTurn(1 || 2) << " starts first." << endl;
for (int game = 1; game <= 46; game++)
{
system("CLS");
cout << "Turn #" << game << endl;
dice = rand() % 6 + 1;
x = rand() % 10 + 1;
y = rand() % 10 + 1;
cout << "Dice number: " << dice << endl;
if (dice < 4 && settler > 0)
{
cout << "Settler placed on [" << x << "] [" << y << "]" << endl;
gameBoard(x, y) = "S";
settler = settler--;
if (playerTurn(1))
{
player1Settler = player1Settler + 1;
}
else
{
player2Settler = player2Settler + 1;
}
currentBoardStatus();
}
else if (dice = 4 && castle > 0)
{
cout << "Castle placed on [" << x << "] [" << y << "]" << endl;
gameBoard(x, y) = "C";
castle = castle--;
if (playerTurn(1))
{
player1Castle = player1Castle + 1;
}
else
{
player2Castle = player2Castle + 1;
}
currentBoardStatus();
}
else if (dice = 5 && tower > 0)
{
cout << "Tower placed on [" << x << "] [" << y << "]" << endl;
gameBoard(x, y) = "T";
tower = tower--;
if (playerTurn(1))
{
player1Tower = player1Tower + 1;
}
else
{
player2Tower = player2Tower + 1;
}
currentBoardStatus();
}
else if (dice = 6 && mine > 0)
{
cout << "Mine placed on [" << x << "] [" << y << "]" << endl;
gameBoard(x, y) = "M";
mine = mine--;
if (playerTurn(1))
{
player1Mine = player1Mine + 1;
}
else
{
player2Mine = player2Mine + 1;
}
currentBoardStatus();
}
else
{
cout << "Player skips his/her turn." << endl;
}
nextTurn();
//currentBoardStatus();
system("pause");
}
}
As soon as the loop goes to 16, the entire console application stops responding, and stops there, only letting me exit.

Answer 1

Your code crashes because of
string gameBoard(int i, int j)
{
string arr[10][10];
return arr[i][j];
}
AND
x = rand() % 10 + 1;
y = rand() % 10 + 1;
x and y will have a value between 1 and 10, but the size of arr is 10 and its maximum valid index is 9. Therefore if x or y is 10 (or both), they'll access undefined memory.
Aside from this, there are many flaws with your code like:
dice = 4 when wanting to compare the value (which actually assigns the value 4 to dice as #KeithSmith pointed out)
The fact that you create string arr in int main() and never use it, but declare another string arr inside string gameBoard() and then return an index from it (which is undefined)