C++ Debugging; I can't see a mistake :( [closed] - c++

Question

It's difficult to tell what is being asked here. This question is ambiguous, vague, incomplete, overly broad, or rhetorical and cannot be reasonably answered in its current form. For help clarifying this question so that it can be reopened, visit the help center.
Closed 12 years ago.
So usually after a night of "drinking", I come home and check the level of drunkenness by programming. I decided to make a calculator program. I got an error, and now I can't go to sleep. Can someone please remove me from this misery. What is wrong with this code?
#include <cstdlib>
#include <iostream>
using namespace std;
int main(int argc, char *argv[])
{
double num1;
double num2;
char redo;
char operation;
do
{
cout<< "Please enter your calculation "<< endl;
cin >> num1 >> operation >>num2;
switch operation {
case '+':
cout<< "" <<num1+num2 << endl;
break;
case '/':
cout<< "" <<num1/num2 << endl;
break;
case '*':
cout<< "" <<num1*num2 << endl;
break;
case '/':
cout<< "" <<num1/num2 << endl;
break;
}
while (redo=='y'||redo=='Y');
system("PAUSE");
return EXIT_SUCCESS;
}
My first debug error is at the cout.. I haven't been able to sleep :(
YAY! I'm NOT drunk!! I got it to work!!! Thajink yoou giusy so mcuh!!
Oh, heres the code btw:
#include <cstdlib>
#include <iostream>
using namespace std;
int main(int argc, char *argv[])
{
double num1;
double num2;
char redo;
char operation;
do
{
cout<< "Please enter your calculation "<< endl;
cin >> num1 >> operation >>num2;
switch (operation) {
case '+':
cout<< num1+num2 << endl;
break;
case '-':
cout<< num1-num2 << endl;
break;
case '*':
cout<< num1*num2 << endl;
break;
case '/':
cout<< num1/num2 << endl;
break;
}
cout<<" Do you want to continue? ";
cin>>redo; }
while (redo=='y'||redo=='Y');
}

Answer 1

Your program is missing a closing curly brace for the switch statement; I'm not sure if that's an error in copying the code to the post or if that's what's actually responsible for your woes.
On a somewhat unrelated note, I noticed that at a few spots in your code you've written
cout<< "" <<num1+num2 << endl;
You don't need to print the empty string before printing out the sum; you can just write
cout<< num1 + num2 << endl;
Another issue you might be having is that your code loops with this condition:
while (redo=='y'||redo=='Y');
However, your code never assigns a value to redo, so this has unspecified behavior - it could loop forever, or loop just once.
Hopefully this helps fix things up!

Answer 2

Which cout? You use it 5 times in your program.
You're reading redo without ever assigning a value to it. That's not likely to work right.

Answer 3

You seconda case should be a '-' not a '/'. There aren't enough closing parentheses.
This works for me:
#include <cstdlib>
#include <iostream>
using namespace std;
int main(int argc, char *argv[])
{
double num1;
double num2;
char redo;
char operation;
do
{
cout<< "Please enter your calculation "<< endl;
cin >> num1 >> operation >>num2;
switch (operation )
{
case '+':
cout<< "" <<num1+num2 << endl;
break;
case '-':
cout<< "" <<num1-num2 << endl;
break;
case '*':
cout<< "" <<num1*num2 << endl;
break;
case '/':
cout<< "" <<num1/num2 << endl;
break;
}
}
while (redo=='y'||redo=='Y');
system("PAUSE");
return EXIT_SUCCESS;
}

Answer 4

Some bugs I could see:
There is a missing closing brace } for switch block.
The condition in switch should be in parenthesis:
switch (operation) {
^ ^
There is duplicate case '/'. Case - is missing.
Variable redo is being used uninitialized. You need to ask user if he wants to continue. Read the response in variable redo.
See it