Jumping into C++: Tic Tac Toe game [using enum] [closed] - c++

Question

Closed. This question needs details or clarity. It is not currently accepting answers.
Want to improve this question? Add details and clarify the problem by editing this post.
Closed 6 months ago.
Improve this question
First and foremost, I ask that anyone who is replying consider these factors. Currently I have very-low knowledge in arrays and enumerations, most of the basics are understood such as what you will see below. I have been trying to figure this problem out for 3 days and now I'm asking for help before I keep burning myself out every 45mins-1hr.
Problem: Write a two-player tic-tac-toe game, allowing two humans to play against each other; use
enums when possible to represent the values of the board
#include<iostream>
#include<string>
bool tie = false;
std::string p1, p2;
enum turnbased{token1, token2, empty};
char space[3][3] = {{1, 2, 3}, {4, 5, 6}, {7, 8, 9}};
int row;
int column;
int token;
void board() //producing the required space[][] coordinates to empty squares
{
std::cout << " | | \n";
std::cout <<" "<<space[0][0]<<" | "<<space[0][1]<<" | "<<space[0][2]<<" \n";
std::cout << " ____|____|____\n";
std::cout <<" "<<space[1][0]<<" | "<<space[1][1]<<" | "<<space[1][2]<<" \n";
std::cout << " ____|____|____\n";
std::cout << " | | \n";
std::cout <<" "<<space[2][0]<<" | "<<space[2][1]<<" | "<<space[2][2]<<" \n";
std::cout << " | | \n";
}
void playerswitch()
{
turnbased assignto = token1; //initializing enum type to define token1 for turns to occur
int token = empty; //declaring token to equivalate to enum variable{empty} in position()
if(assignto)
{
std::cout << p1 << " choose slot for - " << token1;
assignto = token2;
}
else(assignto == token2);
{
std::cout << p2 << " choose slot for - " << token2;
assignto;
}
std::cin >> token;
}
void position()
{
if(empty == 1) // positioning array space
{
row = 0;
column = 0;
}
else if(empty == 2)
{
row = 0;
column = 1;
}
else if(empty == 3)
{
row = 0;
column = 2;
}
else if(empty == 4)
{
row = 1;
column = 0;
}
else if(empty == 5)
{
row = 1;
column = 1;
}
else if(empty == 6)
{
row = 1;
column = 2;
}
else if(empty == 7)
{
row = 2;
column = 0;
}
else if(empty == 7)
{
row = 2;
column = 1;
}
else if(empty == 8)
{
row = 2;
column = 2;
}
else(empty < 1 || empty > 9);
{
std::cout << "Invalid!!!" << std::endl;
}
//token check and execution
if(token1 && space[row][column] != token1 && space[row][column] != token2)
{
space[row][column] = token1;
token2;
}
else if(token2 && space[row][column] != token1 && space[row][column] != token2)
{
space[row][column] = token2;
token1;
}
else{
std::cout << "Invalid space!" << std::endl;
position();
}
playerswitch();
board();
}
//win check
bool results()
{
for(int i = 0; i < 3; i++)
{ //checks horizontally and vertically
if(space[i][0] == space[i][1] && space[i][0] == space[i][2] || space[0][i] == space[1][i] && space[0][i] == space[2][i])
return true;
//checks diagonally
if(space[0][0] == space[1][1] && space[1][1] == space[2][2] || space[0][2] == space[1][1] && space[1][1] == space[2][0])
return true;
for(int j = 0; j < 3; j++)
{
if(space[i][j] != token1 && space[i][j] != token2)
{
return false;
}
}
}
tie = true;
return false;
}
int main()
{
std::cout << "Enter the name of the first player: \n";
getline(std::cin, p1);
std::cout << p1 << " is player1 so he/she will play first \n";
std::cout << "Enter the name of the second player: \n";
getline(std::cin, p2);
std::cout << p2 << " is player2 so he/she will play second \n";
while(!results())
{
board();
playerswitch();
position();
results();
}
if(token1 && tie)
{
std::cout << p2 << " wins!" << std::endl;
}
else if(token2 && tie)
{
std::cout << p1 << " wins!" << std::endl;
}
else
{
std::cout << "It's a draw!" << std::endl;
}
}```

Answer 1

I wont fix your code, but I will help you structure it so you can figure it and future problems out yourself.
First, get rid of all global variables. This is important because the way to reason about code is to look at individual parts in isolation. This is the only, the ONLY, way writing code scales.
To do this, define an interface and a clear job for each of your functions. Maybe add structs to keep data together that belongs together.
After you have changed the functions to work only on their input arguments (look up how functions receive arguments and return values), you can test each function on its own. Make sure your function to read in input works. Make sure your function to manipulate the playing field works. Do all this before you plug them together. This is called unit testing.
Once you are convinced, that regardless the data that your function receives it always does a proper job, plug them together and see if the result works. If it doesn't, your first goal is to figure out which function is broken. Go back to unit testing with new test inputs.
Rinse and repeat until your program works correctly.