Cocreateinstance consuming high cpu - c++

Question

I am using a LOGSERVICELib.dll exposed interface methods as logging method in main project. There is abc.h file in main project where it create instance of LOGSERVICELib.dll and uses it's exposed methods to log main project errors. I recently observed that it's making process too slow ,after profiling the code, I found that cocreate instance consuming high cpu along with other CStdio functions* why Cstdio funcitons taking high cpu time(70-80%)?
Cstdiofile::Readstring()
Cstdiofile::writeString()
Cstdiofile::flush()
LogHelper.h( external .h file)
class LogHelper
{
public:
LogHelper()
{
CoInitialize(NULL);
};
~LogHelper()
{
CoUninitialize();
};
static void LogMessage(_bstr_t eventName, _bstr_t logFilePath, _bstr_t logFileName, _bstr_t message)
{
HRESULT hr = S_OK ;
try
{
CComPtr<LOGSERVICELib::ILogUtility> ILog;
if(ILog == NULL)
hr = ILog.CoCreateInstance(__uuidof(LOGSERVICELib::LogUtility));
if( SUCCEEDED( hr ) )
{
hr = pILog->PostMessage( logFilePath, logFileName, eventName, message, L"", L"");
}
}
catch( _com_error& )
{
// forget it
}
}}
stdAfx.h(Main project)
#define LOG_THIS(x) LogHelper::LogMessage( L"Service", _Module.m_bstrLogHelper, _Module.m_LogHelperLogFile, x)
Service.cpp:
void publish()
{
LOG_THIS("published new service");
}

Answer 1

hr = ILog.CoCreateInstance(__uuidof(LOGSERVICELib::LogUtility));
Clearly this code belongs in the constructor of LogHelper. Profiler guided optimization for the win, and you already used the profiler. Good for you. While you're at it, get rid of the f(ILog == NULL) altogether and move the declaration to your class constructor. This way the code that tries to create it always runs.
CComPtr auto-frees the object.
Unfortunately LogMethod is currently static. To fix the performance the available choices are refactor until it isn't static anymore or implement LOGSERVICELib::LogUtility yourself.