How recursively find files with Unicode names in C++? - c++

Question

I found and modify solution from here:
#include <iostream>
#include <windows.h>
#include <vector>
#include <fstream>
using namespace std;
//wofstream out;
void FindFile(const std::wstring &directory)
{
std::wcout << endl << endl << endl << "FindFile(" << directory << ")" << std::endl;
std::wstring tmp = directory + L"\\*";
WIN32_FIND_DATAW file;
HANDLE search_handle = FindFirstFileW(tmp.c_str(), &file);
if (search_handle != INVALID_HANDLE_VALUE)
{
std::vector<std::wstring> directories;
do
{
std::wcout << std::endl;
std::wcout << " [" << file.cFileName << "]" << std::endl;
tmp = directory + L"\\" + std::wstring(file.cFileName);
if (file.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)
{
if ((!lstrcmpW(file.cFileName, L".")) || (!lstrcmpW(file.cFileName, L".."))) {
std::wcout << "continuing..." << std::endl;
}
else {
std::wcout << "saving path to this directory" << std::endl;
directories.push_back(tmp);
}
} else {
std::wcout << "save [" << tmp << "] as file" << std::endl;
}
//std::wcout << tmp << std::endl;
//out << tmp << std::endl;
}
while (FindNextFileW(search_handle, &file));
std::wcout << "all items inside current directory was worked out. close it's handle." << std::endl;
FindClose(search_handle);
for(std::vector<std::wstring>::iterator iter = directories.begin(), end = directories.end(); iter != end; ++iter) {
std::wcout << "recursively find in next directory: [" << *iter << "]" << std::endl;
FindFile(*iter);
}
} else {
std::wcout << "invalid handle value" << std::endl;
}
}
int main()
{
//out.open("C:\\temp\\found.txt");
FindFile(L"C:\\test");
//out.close();
cout << "The end" << endl;
string str;
cin >> str;
return 0;
}
but this code isn't working with folders or files with cyrillic names (but I use Unicode versions of all types and functions!)
Update: Application just finish, without any exceptions, as if all commands was executed.
Update-2 (print-screen):
Who had the same problem? Thanks for any help.
SOLVED
Thanks a lot to #zett42 !
After some refactoring working code looks like:
#include <iostream>
#include <windows.h>
#include <vector>
#include <fstream>
#include <io.h>
#include <fcntl.h>
using namespace std;
vector<wstring> FindFiles(const std::wstring &directory) {
vector<wstring> files;
std::vector<std::wstring> directories;
std::wstring fullPath = directory + L"\\*";
WIN32_FIND_DATAW file;
HANDLE search_handle = FindFirstFileW(fullPath.c_str(), &file);
if (search_handle == INVALID_HANDLE_VALUE)
return files;
do
{
fullPath = directory + L"\\" + std::wstring(file.cFileName);
if (!(file.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY))
files.push_back(fullPath);
else {
if ((lstrcmpW(file.cFileName, L".")) && (lstrcmpW(file.cFileName, L"..")))
directories.push_back(fullPath);
}
}
while (FindNextFileW(search_handle, &file));
FindClose(search_handle);
for(std::vector<std::wstring>::iterator iter = directories.begin(), end = directories.end(); iter != end; ++iter) {
vector<wstring> newFiles = FindFiles(*iter);
files.insert(files.begin(), newFiles.begin(), newFiles.end());
}
return files;
}
int main()
{
_setmode( _fileno(stdout), _O_U16TEXT );
vector<wstring> files = FindFiles(L"E:\\test");
wcout << L"All found files: " << endl;
for (int i = 0; i < files.size(); ++i)
wcout << files[i] << endl;
cout << "The end" << endl;
string str;
cin >> str;
return 0;
}

Answer 1

On Windows, Unicode output to console doesn't work by default, even if you use std::wcout.
To make it work, insert the following line at the beginning of your program:
_setmode( _fileno(stdout), _O_U16TEXT );
_setmode and _fileno are Microsoft specific function.
You may also have to change console font. I'm using Lucida Console which works fine for cyrillic letters.
Complete example:
#include <iostream>
#include <io.h> // _setmode()
#include <fcntl.h> // _O_U16TEXT
int main()
{
// Windows needs a little non-standard magic for Unicode console output.
_setmode( _fileno(stdout), _O_U16TEXT );
std::wcout << L"по русски\n";
}
Example should be saved as UTF-8 encoded file because of the Unicode string literal, but this is not relevant in your case because you don't have Unicode string literals.
I have successfully tested this code under MSVC2015 and MSVC2017 on Win10.