Compiler keeps ignoring cin values ?? help me solve - c++

Question

I am getting a problem while using
cin >> PayRate
and
cin >> H_worked
what could be the problem? Even the compiler doesn't show any errors but when program runs the 2nd and 3rd cin values aren't read by compiler.
Program:
#include <iostream.h>
#include<conio.h>
int main()
{
int employeeName, H_worked;
float PayRate, GrossPay, NetPay;
cout << "Please input your employee's name:";
cin >> employeeName;
cout << "Input hourly wage rate:";
cin >> PayRate;
cout << endl;
cout << "Input hours worked :";
cin >> H_worked;
cout << endl;
if (H_worked > 40)
{
H_worked = H_worked*1.5;
GrossPay = H_worked*PayRate;
cout << "Your employees gross pay for this week is" << GrossPay << endl;
NetPay = GrossPay - (GrossPay* 3.625);
cout << "Your employees net pay is" << NetPay << endl;
}
else (H_worked <= 40);
{
GrossPay = H_worked*PayRate;
cout << "Your employees gross pay for this week is" << GrossPay << endl;
NetPay = GrossPay - (GrossPay*3.625);
cout << "And your employees net pay is" << NetPay << endl;
}
return 0;
getch();
}

Answer 1

You declared employeeName as an int but that does not make any sense as names have letters not numbers. If you are actually entering in character data then this will cause cin to fail and that will make any subsequent call fail as well. This fits with your description of what is happening. To fix this first we need to make employeeName a std::string so we can store letters.
int employeeName, H_worked;
//becomes
std::string employeeName;
int H_worked;
Then we need to change the input method. Since a name can have spaces in it we need to use std::getline instead of >> to get the name as >> will stop when it sees a space.
cout << "Please input your employee's name:";
std::getline(std::cin, employeeName);
You also have a semicolon at the end of your else condition
else (H_worked <= 40);
This means that
{
GrossPay = H_worked*PayRate;
cout << "Your employees gross pay for this week is" << GrossPay << endl;
NetPay = GrossPay - (GrossPay*3.625);
cout << "And your employees net pay is" << NetPay << endl;
}
Will always run as ; ends the else part.
Then we have the issue that you are using non standard includes. In standard c++
#include <iostream.h>
Should be
#include <iostream>
As all standard includes omit the .h. Since all of the standard components live in the std namespace you are also going to have to deal with that. You can either put std:: in front of all the std components or you can put using std::cout;, using std::cin, ect. I would not suggest using using namespace std; for the reasons outlined in Why is “using namespace std;” considered bad practice?