What's wrong with the coding in my array? [closed] - c++

Question

Closed. This question needs to be more focused. It is not currently accepting answers.
Want to improve this question? Update the question so it focuses on one problem only by editing this post.
Closed 8 years ago.
Improve this question
This is code I've written for an array that has 14 slots, each should have 4 in it except for the 6th and 13th slot, which are reverted back to 0. However, it doesn't compile. Does anyone know what I did wrong here?
using namespace std;
#include <iostream>
const int MAX = 14;
int main ()
{
void printArray ();
system ("pause");
return 0;
}
void startArray (int beadArray[MAX])
{
for(int i=0; i<MAX; i++)
{
beadArray[i]=4;
}
beadArray[6]=0;
beadArray[13]=0;
}
//**********************************************//
void printArray ()
{
startArray (int beadArray[MAX]);
for(int i=0; i<MAX; i++)
{
cout<<i;
}
}

Answer 1

startArray (int beadArray[MAX]);
You're trying to declare beadArray and use it in one step. You should declare it before using it:
int beadArray[MAX];
startArray (beadArray);
You also have a multitude of other problems:
using namespace std; has no effect because <iostream> hasn't been #included yet. You shouldn't use a global using namespace std; as well.
system ("PAUSE"); should be replaced. I personally use:
cin.sync();
cin.get();
the compiler doesn't know about the functions when in main(). Before main(), you should put prototypes:
void printArray();
void startArray (int []);
in main() you say void printArray();. When calling a function, just use the function name and arguments:
printArray();
in printArray(), you're outputting i instead of beadArray [i]. There's also no spacing.
global constants are a bad thing to use.
The fixed code I had looks like this:
#include <iostream>
const int MAX = 14;
void startArray (int (&beadArray)[MAX]);
void printArray();
int main ()
{
printArray ();
std::cout << "\n\nPress enter to continue...";
std::cin.sync();
std::cin.get();
return 0;
}
void startArray (int (&beadArray)[MAX])
{
for(int i=0; i<MAX; ++i)
beadArray[i]=4;
beadArray[6]=0;
beadArray[13]=0;
}
void printArray ()
{
int beadArray[MAX];
startArray (beadArray);
for(int i=0; i<MAX; i++)
std::cout << beadArray[i] << ' ';
}
I did leave the constant in, but there's lots you can do to replace it.

Answer 2

Some corrected mistakes :
declare your array outside startArray() function call if you want to use it outsite.
pass the array as reference if you want to modify it
cout << beadArray[i] instead of cout << i
.
using namespace std;
#include <iostream>
const int MAX = 14;
int main ()
{
void printArray ();
system ("pause");
return 0;
}
void startArray (int &beadArray[MAX])
{
for(int i=0; i<MAX; i++)
beadArray[i]=4;
beadArray[6]=0;
beadArray[13]=0;
}
//**********************************************//
void printArray ()
{
int beadArray[MAX];
startArray (beadArray);
for(int i=0; i<MAX; i++)
cout<<beadArray[i];
}